Repository navigation
fix(build): restore 44px mobile tap targets on workspace artifact tabs (#1042) - #1043
Merged
Merged
Conversation
#91) .m-crumb (the artifact breadcrumb tabs in JourneyBar.tsx — the primary way a founder switches between a build's 14 artifacts) measured ~24px tall on a 375px phone, confirmed live against production — well under the 44px floor every other interactive control on the same screen already respects (#339/#940). No mobile rule had ever covered it. Also retargets the #940 phase-bar mobile rule from the stale .m-actbar selector to .m-journey-phases, its real wrapper since JourneyBar.tsx merged the old ActBar + PathBreadcrumb components — .m-actbar no longer matches anything in the rendered DOM, so that rule's intended wrap/padding treatment had silently stopped applying (the sibling .m-acts/.m-actbar-right rules kept working since they key off their own class names, independent of the dead wrapper selector). Closes #91
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found during pre-summit mobile QA (375×667) against real production: the workspace artifact breadcrumb tabs (`.m-crumb`) render at ~24px tall on mobile — under the 44px tap-target floor every other control on the screen already respects — with zero mobile rule covering them.
Also root-caused: a prior mobile fix for the phase-bar wrapper still targeted the stale `.m-actbar` selector, dead since `JourneyBar.tsx`'s refactor wrapped it in `.m-journey-bar > .m-journey-phases` instead — the wrap/padding treatment had silently stopped applying.
Fix
Test plan
Closes #1042
(Note: this fix was accidentally first pushed to the wrong repository, AINative-Studio/cody-builder — that PR/issue have been closed. This is the correct, re-targeted version.)