Repository navigation
fix(build): add 'Keep going' button to resume stalled generation (#1038) - #1040
Merged
Merged
Conversation
Once state.auto became false — via "Take the wheel" or via resuming an in-progress build (START_BUILD's resume path deliberately leaves auto:false per #1033) — artifact generation stopped permanently. The KEEP_GOING reducer action already existed and flips auto back to true, but nothing in the component tree ever dispatched it. Add a "Keep going" button to ArtifactFrame's paused-nav row, shown whenever the build is paused and the active track still has undone/non-errored views remaining (same trackViews(track) lookup useAutoplay.ts uses to decide a track is finished). Clicking it dispatches KEEP_GOING, which flips auto back to true and lets useAutoplay's own gate resume driving generation from wherever the sequence left off. Live-verified against a local dev server: seeded a paused, unfinished build via the existing ?screen=ws&company=&view= deep-link path (which itself dispatches TAKE_THE_WHEEL), confirmed no /api/build/artifact requests were firing, clicked Keep going, and watched autoplay resume driving the full undone sequence — real /api/build/artifact POSTs fired, the design/thesis/wedge views advanced in order, and genuine provider failures (local-dev-only, no AI credentials configured) were retried and surfaced through the existing GEN_FAIL path rather than hanging, exactly as useAutoplay already handles elsewhere.
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Confirmed live tonight (#1038): once a build's `state.auto` becomes `false` — via "Take the wheel," or simply resuming an in-progress build in a new session — artifact generation stops completely and permanently, with no error and no UI path back. The `KEEP_GOING` reducer action (`auto: true`) was already fully implemented but had zero callers anywhere in the component tree.
This PR implements only the conservative fix: a "Keep going →" button wired to the existing `KEEP_GOING` dispatch, shown whenever paused with real work remaining (reuses the exact same "track has undone views" check `useAutoplay.ts` already uses, rather than reinventing it).
Deliberately out of scope: the issue's second suggested direction — decoupling manual `Next ›` navigation from the `auto` gate so on-demand per-view generation could happen independent of autoplay — needs a real product decision and is left untouched in #1038 for that call.
Test plan
Closes (partially) #1038 — the decouple-from-autoplay question stays open for a product decision