Repository navigation
fix(build): remove CodyChatPanel's dead, permanently-disabled chat input - #1035
Merged
Merged
Conversation
The right-hand Cody panel during artifact drafting (screen=ws) had a visible but hardcoded-disabled text input at the bottom, labeled "Guided Q&A coming soon". It shipped as honest BLD-06.1 shell scaffolding before any real guided conversation existed. BLD-06.2 through BLD-06.9 then shipped the real mechanism -- per-step Q&A chips with free-text answers that drive a real regenerate via /api/build/artifact, plus save/version history and the explain-before-build gate -- but nothing ever retired the original placeholder input, so it kept rendering below the now-functional Q&A block: a dead affordance visually promising a chat box that can never work, superseded by a real one a few lines above it. Founders do have a real way to talk to Cody about the current artifact: the Q&A chips + free text in this panel (for views with a question set) and ArtifactFrame's "What should change?" feedback box (every view, once the artifact has content) -- both reach the same feedback-driven regeneration path. This removes only the leftover dead input and its now-unused CSS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Investigated a product observation: "Cody is visible during planning, but the founder can't actually converse with Cody at that stage." Traced the real mechanism end to end before touching anything.
CodyChatPanel.tsx's Q&A chips + free-text field (e.g. "Who feels this problem the most?") genuinely callPOST /api/build/artifactwith the founder's answer and regenerate the artifact — verified via the real fetch body and dispatch, not assumed. A second, broader mechanism (ArtifactFrame.tsx's "What should change?" box) covers every artifact view once it has content, via the same regeneration path.<input>was rendered below the real Q&A block, hardcodeddisabledwith placeholder text "Guided Q&A coming soon." This is confirmed-intentional leftover scaffolding from BLD-06.1 (feat(workspace): merge phase bar + chips into one journey bar; persistent Cody chat panel #976) — meant to be wired live by BLD-06.2/06.3, but those stories (feat(cody-chat): Cody summarizes each step in plain words (BLD-06.2) #982-986, merged in feat(cody-chat): Epic 2 Wave 2 -- step summaries, Q&A revise, save/history, explain-before-build #987) shipped the real mechanism as the Q&A chips instead, and nobody removed the original placeholder. The result: a permanently-dead UI element visually promising a chat box that will never activate, sitting right next to the real (but differently-shaped) way to actually give Cody feedback — exactly what reads as "Cody is visible but you can't talk to it."Fix
Removed the dead
disabledchat input and its two now-unused CSS rules. Updated the existing BLD-06.1 test to assert the element is gone (it previously asserted "present and disabled," locking the placeholder in place) and removed its retired class names from the CSS existence-coverage test. Rewrote the module's doc comment to describe the real, current feedback mechanism instead of referencing the removed placeholder.No new chat infrastructure was built — the real mechanism already existed and works; this only removes what was misleading about its absence.
Test plan
npx vitest run __tests__/components/build/CodyChatPanel.test.tsx __tests__/app/modernist-css-coverage.test.ts— 21/21 pass (TDD red confirmed first)npx tsc --noEmit— clean/buildfunnel (landing → start → build → intake → kickoff), zero console/page errors