Fix integer overflow error in StratifiedCoordinateSampler class - #1
Open
michael-0brien wants to merge 1 commit into
Open
Fix integer overflow error in StratifiedCoordinateSampler class#1michael-0brien wants to merge 1 commit into
StratifiedCoordinateSampler class#1michael-0brien wants to merge 1 commit into
Conversation
Author
|
See also here: tbepler#261 |
Author
|
Looks like this is an auto conversion due to newer versions of torch, but that newer versions of topaz no longer encounter. Until filament picking is upstream, this simple patch does seem to correct the bug! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I am encountering the following issue when running the filament picker through RELION 5.0.1:
Basically, one or more of
i,j, andcare being set totorch.uint32s, rather than Python integers. Looking at the commit history between here and the main repository, I am not sure why this error would occur, except possibly changes to the behavior oftorchin newer versions?Side note: I realize that this is an appropriate issue to raise with the main topaz repository, but I haven't gotten a chance to reproduce the error with a non-filament picking pipeline yet, so wanted to just start by raising the issue here!
Output of
uv pip list: