Build Merkle trees directly from sorted leaves - #550
Open
robknight wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes how Merkle trees are built from
HashMaps. Previously, we would iterate over theHashMap, inserting each node into a full Merkle tree, repeatedly traversing existing paths and writing intermediate nodes that were superseded by later insertions. This is expensive when we have to build a Merkle tree containing thousands of nodes, e.g. when building a large custom predicate module.Building from sorted leaves performs one pass over the final tree structure and stores each leaf and intermediate node exactly once, substantially reducing constructor work and database traffic.