Support sparse array literals in Podlang - #541
Open
robknight wants to merge 1 commit into
Open
Conversation
Allow array elements to specify indices while preserving dense literal syntax and implicit increments. Reject duplicate or unrepresentable indices, lower literals to sparse containers, and print indexed arrays without traversing the entire container.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POD2 arrays can be sparse, with arbitrary indices. Podlang literal array syntax only supports zero-indexed arrays, with no missing indices between elements.
This PR adds syntax for sparse arrays:
Where an index is given, that index must be used. Where an index is not given, the index is that of the immediately preceding entry plus one. If no indices are given, the first entry has the index 0 and each counts up from there, which is the same behaviour as the existing array literal.