Skip to content

Release GIL during resampling #13

Open

Description

@richardsheridan

CFFI implicitly released the GIL by default when calling into libsamplerate, whereas pybind11 keeps the GIL by default. This change in 0.2.0+ leads to major GIL contention in a application where I was successfully getting thread-based parallelism before.

I don't have much experience with pybind11 but it seems {py::gil_scoped_release release; ...} blocks will be needed around calls to src_simple and others.

Activity

  1. added a commit that references this issue on Jan 25, 2024
    a3ba943
  2. tuxu commented on Jan 25, 2024

    @tuxu
    Owner

    Very good point and definitely an oversight. Would you mind giving PR #14 a try?

  3. Bentroen commented on Dec 5, 2024

    @Bentroen

    Was looking exactly for this – I'll be giving it a shot and report back on the results :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions