feat(sdk): edge template prop#28
Open
kacpercierzniewski wants to merge 6 commits into
Open
Conversation
The demo custom edge painted a fixed stroke, so it didn't highlight on select/hover like the built-in edges — a misleading reference. Delegate styling to the SDK's exported useLabelEdgeHover (the same hook LabelEdge uses), keeping only strokeDasharray on top. Selected/hover now match the built-in edge while the edge stays visually dashed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
kacpercierzniewski
requested review from
librowski,
lukasz-jazwa,
piotrblaszczyk and
szymon-t-sc
as code owners
szymon-t-sc
reviewed
Jun 8, 2026
| // `useEdgeTypes` resolves the built-in default plus any Root-level | ||
| // `edgeTemplates`. The local `edgeTypes` prop (direct DiagramContainer mount) | ||
| // is merged last so an explicit per-mount override still wins. | ||
| const resolvedEdgeTypes = useEdgeTypes(); |
Member
There was a problem hiding this comment.
resolvedEdgeTypes and root-level sound very mysterious and don't tell developers what they are.
Maybe something like this would be better?
// It returns the default built-in edge types in WorkflowBuilder,
// for example with ELK, or edges injected by plugins ex. avoiding nodes.
const defaultEdgeTypes = useEdgeTypes();
// EdgeTypes are custom edge types passed as a prop.
const diagramEdgeTypes = useMemo(() => ({ ...resolvedEdgeTypes, ...edgeTypes }), [resolvedEdgeTypes, edgeTypes]);
Rename the vague `resolvedEdgeTypes` local to `baseEdgeTypes` and correct the comment: the value is the built-in `labelEdge` renderer plus app-wide `edgeTemplates` from <WorkflowBuilder.Root>, which the per-mount `edgeTypes` prop overrides — not plugin- or ELK-injected edges. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.