Upgrade Core and Blaze#915
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: Updates the vendored Sourcemeta Core and Blaze dependencies to newer upstream revisions, and adapts JSON BinPack’s build/test setup to the new Blaze module layout. Changes:
Technical Notes: Blaze’s CMake/package changes are largely about making the new module boundaries explicit (headers and link targets) so downstreams can request only the components they need. 🤖 Was this summary useful? React with 👍 or 👎 |
| add_subdirectory(src/foundation) | ||
| endif() | ||
|
|
||
| if(BLAZE_FRAME) |
There was a problem hiding this comment.
BLAZE_FRAME/BLAZE_BUNDLE/BLAZE_FORMAT appear to assume BLAZE_FOUNDATION (and for bundle/format also BLAZE_FRAME) is enabled; if someone disables the prerequisite option, CMake will fail later when adding subdirectories/targets. Consider adding an explicit configure-time dependency check so invalid option combinations fail with a clearer error.
Severity: medium
Other Locations
vendor/blaze/CMakeLists.txt:61vendor/blaze/CMakeLists.txt:65
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com