Push skaffold images only outside pull requests

[shikanime]

What

Set push: false on the skaffold job that the integration workflow generates, so pull-request runs build and render without publishing images.

Why

The integration workflow called the skaffold reusable workflow without a with: block, so the reusable workflow's push default (true) applied to every non-draft pull-request run: PR CI logged in to ghcr and pushed multi-arch images on each synchronize. Image publishing belongs to the release path, which keeps the default.

References

Related: shikanime-labs/manifests#2215

Summary by CodeRabbit

• Bug Fixes
  • Updated the Skaffold integration workflow to disable image pushing during runs, preventing unintended pushes.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 78c9354d-0f2c-4c8f-9fdd-c3cf474e385d

📥 Commits

Reviewing files that changed from the base of the PR and between 1d74f82 and 2832163.

📒 Files selected for processing (1)

• modules/devenv/integrations/github/skaffold.nix

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The Skaffold integration job now disables image pushing when it calls the reusable Skaffold workflow.

Changes

Skaffold integration

Layer / File(s)	Summary
Disable image pushing modules/devenv/integrations/github/skaffold.nix	The integration job passes push = false to the reusable Skaffold workflow.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 28321

Pull-request Skaffold runs will build and render without publishing images, while release behavior remains unchanged. The change is ready to merge.

Suggested reviewers: yorha-operator

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: Skaffold images are pushed only outside pull requests.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/skaffold-push-on-pr

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}