Repository navigation
feat(tracing): stamp sgp evals run and row ids on SGP spans - #545
Open
mohammadatallah-scale wants to merge 8 commits into
Open
mohammadatallah-scale wants to merge 8 commits into
mohammadatallah-scale wants to merge 8 commits into
Conversation
Spans of a task whose task_metadata carries sgp_evals now get flat sgp_evals_generation_run_id, sgp_evals_row_id and sgp_evals_attempt_idx keys on the SGP copy. Sync and async agents read the task in the ACP server. Temporal agents carry it in the workflow memo and activity headers to the worker. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…val attrs Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Author
|
P3 Refuted: continue-as-new keeps the memo (real dev-server run stamps the post-CAN run), |
Local activities go through start_local_activity, which the outbound interceptor did not override, so their spans carried no run or row id. Also pin the worker's interceptor wiring. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ry none Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
mohammadatallah-scale
requested review from
andrewvo-scale,
declan-scale,
max-parke-scale,
prassanna-ravishankar and
xsfa
and removed request for
xsfa
October 7, 2026 12:34
…id cannot strip a queued span Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…load succeeds Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
mohammadatallah-scale
requested review from
stephen-wang24
and removed request for
andrewvo-scale,
max-parke-scale and
xsfa
October 7, 2026 13:05
…o a span flood cannot evict them Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OVE-1253. Pairs with an sgp-evaluations PR that tags each generation-unit task.
The problem. Spans of an evals generation-unit task carry no run or row id, so a spans search cannot find them.
The fix.
trace_idandtask_idare both not the task id.Test plan
Changes since review
This update appears safe to merge; no new issue remains to address.
What we checked:
Summary
SGP eval task run, row, and attempt ids now appear as searchable metadata on the task’s spans. The PR passes those ids through both in-process ACP handlers and Temporal workers, and keeps each span’s attribution fixed from start through upload.
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart LR A[Task metadata] --> B[Task ID registry] B --> C[Capture IDs when span starts] C --> D{Captured IDs?} D -->|Yes| E[Eval span map] D -->|No| F[Plain span map] E --> G[SGP export] F --> G G --> H[Release capture after export]Reviews (5) · Last reviewed commit: "fix(tracing): keep eval span id captures..." · Reviewed by Greptile