AF_INET and AF_INET6 should be of type sa_family_t

[Yamakaky]

It's a define in the includes, but used as a sa_family_t. See sockaddr for example.

[alexcrichton]

Unfortunately these probably can't change at this point, but we could consider change for the next major version bump of libc.

[gnzlbg]

PRs welcome.

[sum12]

sum12@93580ad

I tried to fix it. but am not sure the fix is complete.

[sum12]

Should I create a PR ? I would like to contribute.

[safinaskar]

Breaking release of libc will be released soon, so we can now change type for AF_INET, etc. But I think its type should not be changed, because first argument of socket is c_int. :) There is no perfect solution here. Let's keep everything as is

[GuillaumeGomez]

Breaking release of libc will be released soon, so we can now change type for AF_INET, etc. But I think its type should not be changed, because first argument of socket is c_int. :) There is no perfect solution here. Let's keep everything as is

Based on this comment, should we close this issue then?

[safinaskar]

Based on this comment, should we close this issue then?

According to this poll: #t-libs > Questions and polls about `libc` 1.0 @ 💬 , we should make it sa_family_t, because sa_family_t is smaller than c_int