Summary
Add an adversarial review step for specifications and plans to Patchmill's
planning workflow, before implementation starts.
Motivation
Catching problems at the spec and plan stage saves a lot of churn in later
reviews. Changes at review time are expensive: code must be rewritten, tests
adjusted, and reviewers re-engaged. Changes to a plan are cheap.
Superpower plans contain code blocks. A plan review is therefore essentially a
code review, done before the code exists.
Proposal
- After planning produces a spec and plan, run one or more adversarial
reviewer passes over them with fresh context.
- Reviewers get the spec, the plan, the issue requirements, and acceptance
criteria, and look for gaps, contradictions, wrong assumptions, and risky
design choices.
- Feed review findings back into planning so the plan is revised before any
implementation begins.
Acceptance criteria
- Planning runs an adversarial review of the spec and plan before
implementation.
- Review findings are recorded and acted on (plan revised or finding
explicitly rejected).
- The review step fits the existing Patchmill planning workflow and does not
block unattended runs on human input.
Summary
Add an adversarial review step for specifications and plans to Patchmill's
planning workflow, before implementation starts.
Motivation
Catching problems at the spec and plan stage saves a lot of churn in later
reviews. Changes at review time are expensive: code must be rewritten, tests
adjusted, and reviewers re-engaged. Changes to a plan are cheap.
Superpower plans contain code blocks. A plan review is therefore essentially a
code review, done before the code exists.
Proposal
reviewer passes over them with fresh context.
criteria, and look for gaps, contradictions, wrong assumptions, and risky
design choices.
implementation begins.
Acceptance criteria
implementation.
explicitly rejected).
block unattended runs on human input.