Skip to content

Commit e27931a

Browse files
fix(a11y): normalize social link aria-labels in TeamMember component
Add dynamic name props to GitHub and Personal Site link aria-labels (#8552).
1 parent 046f17d commit e27931a

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

‎src/components/MDX/TeamMember.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ function GroupBadges({group}: {group: string}) {
6868
);
6969
}
7070

71-
// TODO: good alt text for images/links
71+
7272
export function TeamMember({
7373
name,
7474
title,
@@ -143,7 +143,7 @@ export function TeamMember({
143143
{github && (
144144
<div className="me-4">
145145
<ExternalLink
146-
aria-label="GitHub Profile"
146+
aria-label={`${name} on GitHub`}
147147
href={`https://github.com/${github}`}
148148
className="hover:text-primary hover:underline dark:text-primary-dark flex flex-row items-center">
149149
<IconGitHub className="pe-1" /> {github}
@@ -152,7 +152,7 @@ export function TeamMember({
152152
)}
153153
{personal && (
154154
<ExternalLink
155-
aria-label="Personal Site"
155+
aria-label={`${name}'s Personal Site`}
156156
href={`https://${personal}`}
157157
className="hover:text-primary hover:underline dark:text-primary-dark flex flex-row items-center">
158158
<IconLink className="pe-1" /> {personal}

0 commit comments

Comments
 (0)