Cover react/nativemodule/microtasks:microtasks with Stable API guards (#58027) - #58027
Closed
j-piasecki wants to merge 1 commit into
Closed
Cover react/nativemodule/microtasks:microtasks with Stable API guards (#58027)#58027j-piasecki wants to merge 1 commit into
react/nativemodule/microtasks:microtasks with Stable API guards (#58027)#58027j-piasecki wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116612641. |
facebook-github-tools
Bot
added
p: Software Mansion
meta-codesync
Bot
changed the title
react/nativemodule/microtasks:microtasks with Stable API guardsreact/nativemodule/microtasks:microtasks with Stable API guards (#58027)
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Aug 21, 2026
…ds (react#58027) Summary: Classifies `react/nativemodule/microtasks:microtasks` as a private target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/PrivateGuard.h>` to the module's only header, `NativeMicrotasks.h`, and declares the guard dependency in BUCK, CMake, and the podspec. Consumers that opt into `RN_STRICT_API` now get a hard error if they include it directly, with no escape hatch; without that flag the guard is inert, so no existing build changes behaviour. Changelog: [Internal] Differential Revision: D116612641
j-piasecki
force-pushed
the
export-D116612641
branch
from
August 21, 2026 10:40
1fe27e9 to
f5454da
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Aug 25, 2026
…ds (react#58027) Summary: Classifies `react/nativemodule/microtasks:microtasks` as a private target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/PrivateGuard.h>` to the module's only header, `NativeMicrotasks.h`, and declares the guard dependency in BUCK, CMake, and the podspec. Consumers that opt into `RN_STRICT_API` now get a hard error if they include it directly, with no escape hatch; without that flag the guard is inert, so no existing build changes behaviour. Changelog: [Internal] Differential Revision: D116612641
j-piasecki
force-pushed
the
export-D116612641
branch
from
August 25, 2026 06:35
f5454da to
0de2563
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Aug 26, 2026
…ds (react#58027) Summary: Classifies `react/nativemodule/microtasks:microtasks` as a private target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/PrivateGuard.h>` to the module's only header, `NativeMicrotasks.h`, and declares the guard dependency in BUCK, CMake, and the podspec. Consumers that opt into `RN_STRICT_API` now get a hard error if they include it directly, with no escape hatch; without that flag the guard is inert, so no existing build changes behaviour. Changelog: [Internal] Differential Revision: D116612641
j-piasecki
force-pushed
the
export-D116612641
branch
from
August 26, 2026 07:29
0de2563 to
87b7e0f
Compare
cortinico
approved these changes
Sep 1, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 2, 2026
…ds (react#58027) Summary: Classifies `react/nativemodule/microtasks:microtasks` as a private target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/PrivateGuard.h>` to the module's only header, `NativeMicrotasks.h`, and declares the guard dependency in BUCK, CMake, and the podspec. Consumers that opt into `RN_STRICT_API` now get a hard error if they include it directly, with no escape hatch; without that flag the guard is inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D116612641
j-piasecki
force-pushed
the
export-D116612641
branch
from
September 2, 2026 07:12
87b7e0f to
6978991
Compare
…ds (react#58027) Summary: Classifies `react/nativemodule/microtasks:microtasks` as a private target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/PrivateGuard.h>` to the module's only header, `NativeMicrotasks.h`, and declares the guard dependency in BUCK, CMake, and the podspec. Consumers that opt into `RN_STRICT_API` now get a hard error if they include it directly, with no escape hatch; without that flag the guard is inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D116612641
j-piasecki
force-pushed
the
export-D116612641
branch
from
September 2, 2026 07:15
6978991 to
6a466cc
Compare
|
This pull request has been merged in 16f8889. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Classifies
react/nativemodule/microtasks:microtasksas a private target under the C++ stable API three-tier visibility model. Adds#include <react/cxxstableapi/PrivateGuard.h>to the module's only header,NativeMicrotasks.h, and declares the guard dependency in BUCK, CMake, and the podspec. Consumers that opt intoRN_STRICT_APInow get a hard error if they include it directly, with no escape hatch; without that flag the guard is inert, so no existing build changes behaviour.Changelog: [Internal]
Reviewed By: cortinico
Differential Revision: D116612641