Deprecate old-arch bridge APIs unused by interop (#59544)

Summary:

Mark the remaining old-architecture `RCTBridge` APIs that nothing in the interop layer calls as deprecated, so downstream modules get one release of warnings before removal: segment registration, executor/launch/loading/validity/performance accessors, fast refresh, callback enqueue, `batchedBridge`, block dispatch, extra module classes, and the old-arch module list. Silence the resulting warnings at the six first-party call sites.

Changelog:
[iOS][Deprecated] - Deprecate unused old-architecture `RCTBridge` APIs ahead of removal

Reviewed By: andrewdacenko

Differential Revision: D127822075

Pull Request resolved: #59544

Author: christophpurrer

packages/react-native/React/Base/RCTBridge+Private.h

@@ -24,14 +24,17 @@ RCT_EXTERN void RCTRegisterModule(Class);
  * This method is used to invoke a callback that was registered in the
  * JavaScript application context. Safe to call from any thread.
  */
-- (void)enqueueCallback:(NSNumber *)cbID args:(NSArray *)args;
+- (void)enqueueCallback:(NSNumber *)cbID
+                   args:(NSArray *)args
+    __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**
  * This property is mostly used on the main thread, but may be touched from
  * a background thread if the RCTBridge happens to deallocate on a background
  * thread. Therefore, we want all writes to it to be seen atomically.
  */
-@property (atomic, strong) RCTBridge *batchedBridge;
+@property (atomic, strong)
+    RCTBridge *batchedBridge __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**
  * An object that allows one to require NativeModules/TurboModules.
@@ -48,11 +51,14 @@ RCT_EXTERN void RCTRegisterModule(Class);
  * Dispatch work to a module's queue - this is also supports the fake RCTJSThread
  * queue. Exposed for the RCTProfiler
  */
-- (void)dispatchBlock:(dispatch_block_t)block queue:(dispatch_queue_t)queue;
+- (void)dispatchBlock:(dispatch_block_t)block
+                queue:(dispatch_queue_t)queue
+    __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**
  * Registers additional classes with the ModuleRegistry.
  */
-- (void)registerAdditionalModuleClasses:(NSArray<Class> *)newModules;
+- (void)registerAdditionalModuleClasses:(NSArray<Class> *)newModules
+    __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 @end

packages/react-native/React/Base/RCTBridge.h

@@ -41,7 +41,8 @@ NSString *RCTBridgeModuleNameForClass(Class bridgeModuleClass);
 /**
  * This function returns the list of modules that have been registered using the Old Architecture mechanism.
  */
-NSMutableArray<NSString *> *getModulesLoadedWithOldArch(void);
+NSMutableArray<NSString *> *getModulesLoadedWithOldArch(void)
+    __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 #ifndef RCT_REMOVE_LEGACY_MODULE_INTEROP
 // Turn on TurboModule interop
@@ -117,7 +118,9 @@ RCT_EXTERN_C_END
  *
  * @experimental
  */
-- (void)registerSegmentWithId:(NSUInteger)segmentId path:(NSString *)path;
+- (void)registerSegmentWithId:(NSUInteger)segmentId
+                         path:(NSString *)path
+    __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**
  * Retrieve a bridge module instance by name or class. Note that modules are
@@ -157,31 +160,36 @@ RCT_EXTERN_C_END
  * The class of the executor currently being used. Changes to this value will
  * take effect after the bridge is reloaded.
  */
-@property (nonatomic, strong) Class executorClass;
+@property (nonatomic, strong)
+    Class executorClass __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**
  * The launch options that were used to initialize the bridge.
  */
-@property (nonatomic, copy, readonly) NSDictionary *launchOptions;
+@property (nonatomic, copy, readonly)
+    NSDictionary *launchOptions __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**
  * Use this to check if the bridge is currently loading.
  */
-@property (nonatomic, readonly, getter=isLoading) BOOL loading;
+@property (nonatomic, readonly, getter=isLoading)
+    BOOL loading __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**
  * Use this to check if the bridge has been invalidated.
  */
-@property (nonatomic, readonly, getter=isValid) BOOL valid;
+@property (nonatomic, readonly, getter=isValid)
+    BOOL valid __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**
  * Link to the Performance Logger that logs React Native perf events.
  */
-@property (nonatomic, readonly, strong) RCTPerformanceLogger *performanceLogger;
+@property (nonatomic, readonly, strong) RCTPerformanceLogger *performanceLogger __deprecated_msg(
+    "This API will be removed along with the legacy architecture.");
 
 /**
  * Handle notifications for a fast refresh. Safe to call from any thread.
  */
-- (void)onFastRefresh;
+- (void)onFastRefresh __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 @end

packages/react-native/React/Base/Surface/SurfaceHostingView/RCTSurfaceHostingProxyRootView.mm

@@ -117,7 +117,10 @@ - (void)surface:(RCTSurface *)surface didChangeStage:(RCTSurfaceStage)stage
 {
   [super surface:surface didChangeStage:stage];
   if (RCTSurfaceStageIsRunning(stage)) {
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
     [_bridge.performanceLogger markStopForTag:RCTPLTTI];
+#pragma clang diagnostic pop
 #if TARGET_OS_TV
     dispatch_async(dispatch_get_main_queue(), ^{
       self.reactPreferredFocusedView = nil;

packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTInstance.mm

@@ -553,7 +553,10 @@ - (void)_logOldArchitectureWarnings
     return;
   }
 
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
   NSArray<NSString *> *modulesInOldArchMode = [getModulesLoadedWithOldArch() copy];
+#pragma clang diagnostic pop
   if (modulesInOldArchMode.count > 0) {
     NSMutableString *moduleList = [NSMutableString new];
     for (NSString *moduleName in modulesInOldArchMode) {