Skip to content

Commit 9994431

Browse files
j-piaseckimeta-codesync[bot]
authored andcommitted
Cover componentregistry/native with guards (#58141)
Summary: Pull Request resolved: #58141 Classifies `react/renderer/componentregistry/native:native` as a private target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/PrivateGuard.h>` to the module's single exported header (`NativeComponentRegistryBinding.h`), and wires the guard dependency into BUCK and CMake. The `React-Fabric` pod that ships this module already depends on `React-cxxstableapi` and is marked as a React Native build, so no podspec change is needed. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D117338950 fbshipit-source-id: 46c758749d467cd3ab9acf569ecbc77ba3caacaa
1 parent 911e8fc commit 9994431

2 files changed

Lines changed: 3 additions & 0 deletions

File tree

packages/react-native/ReactCommon/react/renderer/componentregistry/native/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ target_link_libraries(rrc_native
1717
folly_runtime
1818
glog_init
1919
jsi
20+
react_cxxstableapi
2021
react_debug
2122
react_renderer_core
2223
react_renderer_debug

packages/react-native/ReactCommon/react/renderer/componentregistry/native/NativeComponentRegistryBinding.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#include <string>
1113

1214
#include <jsi/jsi.h>

0 commit comments

Comments
 (0)