Delete dead RCTBridge public API and skipped logging tests

Summary:
Remove `RCTBridge` declarations with zero callers: `enqueueJSCall`, module lookup, `delegate`, `moduleClasses`, reload, and batch APIs, plus their stub implementations. Keep `bundleURL`, still read by Expo Dev Menu, and the TurboModule-registry hooks the proxy forwards through, all marked deprecated. Delete skipped `RCTLoggingTests`, the only `enqueueJSCall` caller.

Changelog:
[iOS][Removed] - Remove unused `RCTBridge` reload, module-lookup, and JS-callback APIs
[iOS][Deprecated] - Deprecate `RCTBridge.bundleURL`, `setRCTTurboModuleRegistry:`, and `bridgeModuleDecorator`

Reviewed By: andrewdacenko

Differential Revision: D127265582

Author: christophpurrer

packages/react-native/React/Base/RCTBridge.h

@@ -112,17 +112,6 @@ RCT_EXTERN_C_END
                     launchOptions:(NSDictionary *)launchOptions
     __deprecated_msg("This API will be removed along with the legacy architecture.");
 
-/**
- * This method is used to call functions in the JavaScript application context.
- * It is primarily intended for use by modules that require two-way communication
- * with the JavaScript code. Safe to call from any thread.
- */
-- (void)enqueueJSCall:(NSString *)moduleDotMethod args:(NSArray *)args;
-- (void)enqueueJSCall:(NSString *)module
-               method:(NSString *)method
-                 args:(NSArray *)args
-           completion:(dispatch_block_t)completion;
-
 /**
  * This method registers the file path of an additional JS segment by its ID.
  *
@@ -147,50 +136,29 @@ RCT_EXTERN_C_END
  * When a NativeModule performs a lookup for a TurboModule, we need to query
  * the TurboModuleRegistry.
  */
-- (void)setRCTTurboModuleRegistry:(id<RCTTurboModuleRegistry>)turboModuleRegistry;
+- (void)setRCTTurboModuleRegistry:(id<RCTTurboModuleRegistry>)turboModuleRegistry
+    __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**
  * This hook is called by the TurboModule infra with every ObjC module that's created.
  * It allows the bridge to attach properties to ObjC modules that give those modules
  * access to Bridge APIs.
  */
-- (RCTBridgeModuleDecorator *)bridgeModuleDecorator;
-
-/**
- * Convenience method for retrieving all modules conforming to a given protocol.
- * Modules will be synchronously instantiated if they haven't already been,
- * potentially blocking both the calling thread and main thread for a short time.
- */
-- (NSArray *)modulesConformingToProtocol:(Protocol *)protocol;
-
-/**
- * Test if a module has been initialized. Use this prior to calling
- * `moduleForClass:` or `moduleForName:` if you do not want to cause the module
- * to be instantiated if it hasn't been already.
- */
-- (BOOL)moduleIsInitialized:(Class)moduleClass;
-
-/**
- * All registered bridge module classes.
- */
-@property (nonatomic, copy, readonly) NSArray<Class> *moduleClasses;
+- (RCTBridgeModuleDecorator *)
+    bridgeModuleDecorator __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**
  * URL of the script that was loaded into the bridge.
  */
-@property (nonatomic, strong, readonly) NSURL *bundleURL;
+@property (nonatomic, strong, readonly)
+    NSURL *bundleURL __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**
  * The class of the executor currently being used. Changes to this value will
  * take effect after the bridge is reloaded.
  */
 @property (nonatomic, strong) Class executorClass;
 
-/**
- * The delegate provided during the bridge initialization
- */
-@property (nonatomic, weak, readonly) id<RCTBridgeDelegate> delegate;
-
 /**
  * The launch options that were used to initialize the bridge.
  */
@@ -211,29 +179,9 @@ RCT_EXTERN_C_END
  */
 @property (nonatomic, readonly, strong) RCTPerformanceLogger *performanceLogger;
 
-/**
- * Reload the bundle and reset executor & modules. Safe to call from any thread.
- */
-- (void)reload __deprecated_msg("Use RCTReloadCommand instead");
-
-/**
- * Reload the bundle and reset executor & modules. Safe to call from any thread.
- */
-- (void)reloadWithReason:(NSString *)reason __deprecated_msg("Use RCTReloadCommand instead");
-
 /**
  * Handle notifications for a fast refresh. Safe to call from any thread.
  */
 - (void)onFastRefresh;
 
-/**
- * Inform the bridge, and anything subscribing to it, that it should reload.
- */
-- (void)requestReload __deprecated_msg("Use RCTReloadCommand instead");
-
-/**
- * Says whether bridge has started receiving calls from JavaScript.
- */
-- (BOOL)isBatchActive;
-
 @end

packages/react-native/React/Base/RCTBridge.mm

@@ -231,17 +231,6 @@ - (instancetype)initWithBundleURL:(NSURL *)bundleURL
   return self;
 }
 
-- (void)enqueueJSCall:(NSString *)moduleDotMethod args:(NSArray *)args
-{
-}
-
-- (void)enqueueJSCall:(NSString *)module
-               method:(NSString *)method
-                 args:(NSArray *)args
-           completion:(__strong dispatch_block_t)completion
-{
-}
-
 - (void)registerSegmentWithId:(NSUInteger)segmentId path:(NSString *)path
 {
 }
@@ -270,37 +259,10 @@ - (RCTBridgeModuleDecorator *)bridgeModuleDecorator
   return nil;
 }
 
-- (NSArray *)modulesConformingToProtocol:(Protocol *)protocol
-{
-  return @[];
-}
-
-- (BOOL)moduleIsInitialized:(Class)moduleClass
-{
-  return NO;
-}
-
-- (void)reload __attribute__((deprecated("Use RCTReloadCommand instead")))
-{
-}
-
-- (void)reloadWithReason:(NSString *)reason __attribute__((deprecated("Use RCTReloadCommand instead")))
-{
-}
-
 - (void)onFastRefresh
 {
 }
 
-- (void)requestReload __attribute__((deprecated("Use RCTReloadCommand instead")))
-{
-}
-
-- (BOOL)isBatchActive
-{
-  return NO;
-}
-
 - (void)enqueueCallback:(NSNumber *)cbID args:(NSArray *)args
 {
 }

packages/rn-tester/RNTesterIntegrationTests/RCTLoggingTests.m

@@ -652,28 +652,18 @@ interface RCTBlobManager : public NSObject <RCTBridgeModule, RCTURLRequestHandle
 interface RCTBridge : public NSObject <RCTInvalidating> {
   public @property (assign, readonly) BOOL loading;
   public @property (assign, readonly) BOOL valid;
-  public @property (copy, readonly) NSArray<Class>* moduleClasses;
   public @property (copy, readonly) NSDictionary* launchOptions;
   public @property (strong) Class executorClass;
   public @property (strong, readonly) NSURL* bundleURL;
   public @property (strong, readonly) RCTPerformanceLogger* performanceLogger;
-  public @property (weak, readonly) id<RCTBridgeDelegate> delegate;
-  public virtual BOOL isBatchActive();
-  public virtual BOOL moduleIsInitialized:(Class moduleClass);
-  public virtual NSArray* modulesConformingToProtocol:(Protocol* protocol);
   public virtual RCTBridgeModuleDecorator* bridgeModuleDecorator();
   public virtual id moduleForClass:(Class moduleClass);
   public virtual id moduleForName:(NSString* moduleName);
   public virtual id moduleForName:lazilyLoadIfNecessary:(NSString* moduleName, BOOL lazilyLoad);
   public virtual instancetype initWithBundleURL:moduleProvider:launchOptions:(NSURL* bundleURL, RCTBridgeModuleListProvider block, NSDictionary* launchOptions);
   public virtual instancetype initWithDelegate:launchOptions:(id<RCTBridgeDelegate> delegate, NSDictionary* launchOptions);
-  public virtual void enqueueJSCall:args:(NSString* moduleDotMethod, NSArray* args);
-  public virtual void enqueueJSCall:method:args:completion:(NSString* module, NSString* method, NSArray* args, dispatch_block_t completion);
   public virtual void onFastRefresh();
   public virtual void registerSegmentWithId:path:(NSUInteger segmentId, NSString* path);
-  public virtual void reload();
-  public virtual void reloadWithReason:(NSString* reason);
-  public virtual void requestReload();
   public virtual void setRCTTurboModuleRegistry:(id<RCTTurboModuleRegistry> turboModuleRegistry);
 }
 

scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api

@@ -661,28 +661,18 @@ interface RCTBlobManager : public NSObject <RCTBridgeModule, RCTURLRequestHandle
 interface RCTBridge : public NSObject <RCTInvalidating> {
   public @property (assign, readonly) BOOL loading;
   public @property (assign, readonly) BOOL valid;
-  public @property (copy, readonly) NSArray<Class>* moduleClasses;
   public @property (copy, readonly) NSDictionary* launchOptions;
   public @property (strong) Class executorClass;
   public @property (strong, readonly) NSURL* bundleURL;
   public @property (strong, readonly) RCTPerformanceLogger* performanceLogger;
-  public @property (weak, readonly) id<RCTBridgeDelegate> delegate;
-  public virtual BOOL isBatchActive();
-  public virtual BOOL moduleIsInitialized:(Class moduleClass);
-  public virtual NSArray* modulesConformingToProtocol:(Protocol* protocol);
   public virtual RCTBridgeModuleDecorator* bridgeModuleDecorator();
   public virtual id moduleForClass:(Class moduleClass);
   public virtual id moduleForName:(NSString* moduleName);
   public virtual id moduleForName:lazilyLoadIfNecessary:(NSString* moduleName, BOOL lazilyLoad);
   public virtual instancetype initWithBundleURL:moduleProvider:launchOptions:(NSURL* bundleURL, RCTBridgeModuleListProvider block, NSDictionary* launchOptions);
   public virtual instancetype initWithDelegate:launchOptions:(id<RCTBridgeDelegate> delegate, NSDictionary* launchOptions);
-  public virtual void enqueueJSCall:args:(NSString* moduleDotMethod, NSArray* args);
-  public virtual void enqueueJSCall:method:args:completion:(NSString* module, NSString* method, NSArray* args, dispatch_block_t completion);
   public virtual void onFastRefresh();
   public virtual void registerSegmentWithId:path:(NSUInteger segmentId, NSString* path);
-  public virtual void reload();
-  public virtual void reloadWithReason:(NSString* reason);
-  public virtual void requestReload();
   public virtual void setRCTTurboModuleRegistry:(id<RCTTurboModuleRegistry> turboModuleRegistry);
 }
 

scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api

@@ -652,28 +652,18 @@ interface RCTBlobManager : public NSObject <RCTBridgeModule, RCTURLRequestHandle
 interface RCTBridge : public NSObject <RCTInvalidating> {
   public @property (assign, readonly) BOOL loading;
   public @property (assign, readonly) BOOL valid;
-  public @property (copy, readonly) NSArray<Class>* moduleClasses;
   public @property (copy, readonly) NSDictionary* launchOptions;
   public @property (strong) Class executorClass;
   public @property (strong, readonly) NSURL* bundleURL;
   public @property (strong, readonly) RCTPerformanceLogger* performanceLogger;
-  public @property (weak, readonly) id<RCTBridgeDelegate> delegate;
-  public virtual BOOL isBatchActive();
-  public virtual BOOL moduleIsInitialized:(Class moduleClass);
-  public virtual NSArray* modulesConformingToProtocol:(Protocol* protocol);
   public virtual RCTBridgeModuleDecorator* bridgeModuleDecorator();
   public virtual id moduleForClass:(Class moduleClass);
   public virtual id moduleForName:(NSString* moduleName);
   public virtual id moduleForName:lazilyLoadIfNecessary:(NSString* moduleName, BOOL lazilyLoad);
   public virtual instancetype initWithBundleURL:moduleProvider:launchOptions:(NSURL* bundleURL, RCTBridgeModuleListProvider block, NSDictionary* launchOptions);
   public virtual instancetype initWithDelegate:launchOptions:(id<RCTBridgeDelegate> delegate, NSDictionary* launchOptions);
-  public virtual void enqueueJSCall:args:(NSString* moduleDotMethod, NSArray* args);
-  public virtual void enqueueJSCall:method:args:completion:(NSString* module, NSString* method, NSArray* args, dispatch_block_t completion);
   public virtual void onFastRefresh();
   public virtual void registerSegmentWithId:path:(NSUInteger segmentId, NSString* path);
-  public virtual void reload();
-  public virtual void reloadWithReason:(NSString* reason);
-  public virtual void requestReload();
   public virtual void setRCTTurboModuleRegistry:(id<RCTTurboModuleRegistry> turboModuleRegistry);
 }