file resource repeatedly logs 'chmod' in some cases

[jordansissel]

Sample mcl:

file "/tmp/x/" {
  owner => "nginx",
  group => "apache",
  mode => "755",
  state => "exists",
}

Caveat: I am using a baddev branch chasing master and haven't tested a release. I'm currently only on my mac and reproduced this on linux arm64 in a vm, not yet tested linux x86_64.

---

Problem: mgmt gets stuck in a loop doing chmod?

[dev@localhost ~]$ mgmt --version
1.1.0-111-g12bb98bd

[dev@localhost ~]$ sudo mgmt run lang /tmp/x.mcl
05:34:44 main: graph: Vertices(1), Edges(0)
05:34:44 main: waiting...
05:34:44 engine: file[/tmp/a/]: mkdir -m -rwxr-xr-x
05:34:44 engine: file[/tmp/a/]: chown nginx:apache
05:34:44 engine: file[/tmp/a/]: chmod 755
05:34:44 engine: file[/tmp/a/]: chmod 755
05:34:44 engine: file[/tmp/a/]: chmod 755
05:34:44 engine: file[/tmp/a/]: chmod 755
05:34:44 engine: file[/tmp/a/]: chmod 755
05:34:44 engine: file[/tmp/a/]: chmod 755
<endless....>

In case it's unique to this use case -- here's the apache group and nginx user info:

[dev@localhost ~]$ getent group apache
apache:x:48:
[dev@localhost ~]$ getent passwd nginx
nginx:x:991:991:Nginx web server:/var/lib/nginx:/sbin/nologin

[purpleidea]

Weird! That is unique. The obvious first thing I'd check is to make sure there isn't something else changing it back...

If you'd like to debug, I'd recommend adding a Printf in the Watch() method for that resource and seeing if new events are being generated... I assume yes... How often does the chmod happen? Every ~1ms-10ms or 1s? (eg: really fast or not?)

Secondly, I'd expect if there was a bug, it would be chmodCheckApply https://github.com/purpleidea/mgmt/blob/master/engine/resources/file.go#L1272

It's important that it does not make a change if it's already the correct state. That might be the bug.

Can you try with the symbolic mode as well? Eg: mode => "u=rwx,go=rx", and confirm if it happens or not? If it doesn't happen anymore, then it might just be a bug with the chmod numeric parser.

HTH and thanks for the report!

[purpleidea]

Actually... I can repro :P How do you find these!

Let me debug...

[purpleidea]

A: drwxr-xr-x, B: -rwxr-xr-x

aha

[purpleidea]

The bug is dest is a dir, but you've set a non-dir mode. I don't think this should be counted as a user error, let me think how best to fix it.

[purpleidea]

And I can confirm the mode => symbolic workaround works. So please use that for the moment. (It's probably better to always use that anyways.)

[purpleidea]

Patch incoming... Trying to meet our internal SLA's!

[purpleidea]

b5f968d

Testing in CI now.

[purpleidea]

Fix merged, thank you for the report! \o/