Skip to content

Commit 929ddfe

Browse files
committed
test,inspector: improve network event coverage
Signed-off-by: GrinZero <774933704@qq.com>
1 parent 4bd2033 commit 929ddfe

2 files changed

Lines changed: 38 additions & 2 deletions

File tree

test/parallel/test-inspector-emit-protocol-event-errors.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -190,6 +190,17 @@ const NETWORK_ERROR_CASES = [
190190
}),
191191
'Invalid initiator.stack in event',
192192
],
193+
[
194+
'requestWillBeSent',
195+
networkRequest({
196+
requestId: 'request-id-invalid-initiator-stack-type',
197+
initiator: {
198+
type: 'script',
199+
stack: [],
200+
},
201+
}),
202+
'Invalid initiator.stack in event',
203+
],
193204
[
194205
'requestWillBeSent',
195206
networkRequest({

test/parallel/test-inspector-emit-protocol-event.js

Lines changed: 27 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,16 +197,41 @@ for (const [domain, events] of Object.entries(EXPECTED_EVENTS)) {
197197

198198
session.removeAllListeners('Network.requestWillBeSent');
199199
{
200-
const customInitiator = {
200+
const expectedInitiator = {
201201
type: 'script',
202202
stack: {
203+
description: 'custom stack',
203204
callFrames: [{
204205
functionName: 'customFunction',
205206
scriptId: 'customScript',
206207
url: 'file:///custom.js',
207208
lineNumber: 12,
208209
columnNumber: 34,
209210
}],
211+
parent: {
212+
description: 'parent stack',
213+
callFrames: [{
214+
functionName: 'parentFunction',
215+
scriptId: 'parentScript',
216+
url: 'file:///parent.js',
217+
lineNumber: 56,
218+
columnNumber: 78,
219+
}],
220+
},
221+
},
222+
url: 'file:///initiator.js',
223+
lineNumber: 90,
224+
columnNumber: 12,
225+
requestId: 'previous-request-id',
226+
};
227+
const customInitiator = {
228+
...expectedInitiator,
229+
stack: {
230+
...expectedInitiator.stack,
231+
ignoredNull: null,
232+
ignoredUndefined: undefined,
233+
ignoredBoolean: true,
234+
ignoredNumber: 1.5,
210235
},
211236
};
212237
const requestWillBeSent = once(session, 'Network.requestWillBeSent');
@@ -216,7 +241,7 @@ for (const [domain, events] of Object.entries(EXPECTED_EVENTS)) {
216241
initiator: customInitiator,
217242
});
218243
const [{ params }] = await requestWillBeSent;
219-
assert.deepStrictEqual(params.initiator, customInitiator);
244+
assert.deepStrictEqual(params.initiator, expectedInitiator);
220245
}
221246

222247
session.removeAllListeners('Network.requestWillBeSent');

0 commit comments

Comments
 (0)