Method which returns `list<T>`

[nikophil]

Hello,

We're typing a lot our arrays as list<T>

usually we're using array_values() to ensure we have a list. But it feels really cumbersome to do something like array_values(listOf($foo)->toArray())

Would you be OK to add something like this?

// \Noctud\Collection\Collection

	/**
	 * Convert to a primitive PHP array list preserving iteration order.
	 *
	 * @return list<E>
	 */
	#[NoDiscard]
	public function toArrayList(): array;

not sure about the method's name. In doctrine/collection it is called getValues()

[delacry]

Hello, so the difference between current behavior and this is that list guarantees the index order 0, 1, 2..., so I wonder if changing toArray() return type won't be better option, because it must be guaranteed list (because there are no keys), so it's more accurate, and every list<E> is array<int,E> so it shouldn't be a BC break.

[nikophil]

At first I was thinking that Collection was a shared interface between the three data structure Set / List / Map, hence my suggestion. But since Map does not implement Collection, I think this solution is even better 👍

[delacry]

Yeah, shared interface would be a footgun.. I have to admit, one moment I was really considering it while designing the library, but I decided against. I'll look at it maybe Sunday, or feel free to send a PR, it's probably just an annotation change in Collection interface and maybe ReadOnlyElementStore.