Repository navigation
fix(ci): build the release APKs with build-fdroid.sh, then sign them - #1677
Conversation
The release ran a plain flutter build through fl_build, which compiles a different libapp.so from what F-Droid rebuilds with build-fdroid.sh. Refs #1274
|
Important Review completed Reviewed commit Merge risk: 🟢 Low · no blocking findings 📝 Walkthrough
Commenting |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📜 Recent review details🔇 Additional comments (3)
📝 WalkthroughWalkthroughThe Android workflow now builds APKs for each matrix ABI with ChangesF-Droid Android build
Suggested reviewers: Priority: ➖ Normal Change: Bug fix Merge Risk: ⚪ Minimal · up to The release workflow now builds APKs with the F-Droid build script and then signs them. No concrete merge-blocking risk was found in the supplied changes. Run the release workflow once to confirm the signed artifacts.
Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
✅ No blocking issues found — approving.
ℹ️ Review info
⚙️ Run configuration
Configuration: defaults
Review profile: balanced
Model: gpt-6-luna
📥 Commits
Reviewing files that changed between 40e734a and b7b3a6f.
📒 Files selected for processing (2)
.github/workflows/build.ymlscripts/release/prepare-fdroid.sh
Coverage
- 1 of 1 areas reviewed
Refs #1274
Summary
Changes
Summary by CodeRabbit