From 99fa08289af8bcc333749f3b867bc8703c5f345d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Pineau?= Date: Sat, 26 Sep 2026 00:58:02 +0200 Subject: [PATCH] fix(ci): Use the actor as username in the registry login The username was a bare "$": GHCR accepts any username with a GITHUB_TOKEN, so it worked by accident. --- .github/workflows/cache.yml | 2 +- .github/workflows/ci.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/cache.yml b/.github/workflows/cache.yml index 1f0e0f9..f62e591 100644 --- a/.github/workflows/cache.yml +++ b/.github/workflows/cache.yml @@ -19,7 +19,7 @@ jobs: - name: Log in to registry shell: bash - run: echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u $ --password-stdin + run: echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u "${{ github.actor }}" --password-stdin - name: setup-castor uses: castor-php/setup-castor@2a495b8c91f00be6768ad8a040ba8634c797d386 # v1.1.0 diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f061a97..72ea2d1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -45,7 +45,7 @@ jobs: - name: Log in to the Container registry shell: bash - run: echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u $ --password-stdin + run: echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u "${{ github.actor }}" --password-stdin - name: setup-castor uses: castor-php/setup-castor@2a495b8c91f00be6768ad8a040ba8634c797d386 # v1.1.0