Repository navigation
add missing docstrings to three public functions in utils/imports.py - #1282
Closed
RavSinghChandan wants to merge 1 commit into
Closed
RavSinghChandan wants to merge 1 commit into
RavSinghChandan wants to merge 1 commit into
Conversation
…_package_not_available, parse_specified_backends
Author
|
Closing this since it's been open a while without review. Happy to reopen if it's still useful. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three public functions in
src/lighteval/utils/imports.pyhad no docstrings while the surrounding functions (is_package_available,required_dependencies,not_installed_error_message,requires) all do.Added docstrings matching the existing style in the file:
is_multilingual_package_available— explains which packages are checked and the language-specific additions for Vietnamese and Chineseraise_if_package_not_available— describes the multilingual special-case and how the error message is constructedparse_specified_backends— explains what it resolves and when it raisesNo logic changes.