diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml index 5b5d2c73b..00636883c 100644 --- a/.github/workflows/master.yml +++ b/.github/workflows/master.yml @@ -324,7 +324,7 @@ jobs: --data "{\"event\":\"deploy\",\"service\":\"handsontable-demos-authoring\",\"sha\":\"${GITHUB_SHA}\",\"cf_version_id\":\"${VERSION_ID}\"}") \ || true echo "deploy-event response: ${code:-}" - [ "$code" = "200" ] || echo "::warning::deploy event for handsontable-demos-authoring did not return 200 (${code:-})" + [ "$code" = "204" ] || [ "$code" = "200" ] || echo "::warning::deploy event for handsontable-demos-authoring did not return 204 (${code:-})" - name: Smoke test — prod frontend serves current bundle working-directory: . @@ -450,7 +450,7 @@ jobs: --data "{\"event\":\"deploy\",\"service\":\"handsontable-demos-api\",\"sha\":\"${GITHUB_SHA}\",\"cf_version_id\":\"${VERSION_ID}\"}") \ || true echo "deploy-event response: ${code:-}" - [ "$code" = "200" ] || echo "::warning::deploy event for handsontable-demos-api did not return 200 (${code:-})" + [ "$code" = "204" ] || [ "$code" = "200" ] || echo "::warning::deploy event for handsontable-demos-api did not return 204 (${code:-})" - name: Smoke test — prod API health working-directory: . @@ -538,4 +538,4 @@ jobs: --data "{\"event\":\"deploy\",\"service\":\"handsontable-demos-o11y\",\"sha\":\"${GITHUB_SHA}\",\"cf_version_id\":\"${VERSION_ID}\"}") \ || true echo "deploy-event response: ${code:-}" - [ "$code" = "200" ] || echo "::warning::deploy event for handsontable-demos-o11y did not return 200 (${code:-})" + [ "$code" = "204" ] || [ "$code" = "200" ] || echo "::warning::deploy event for handsontable-demos-o11y did not return 204 (${code:-})" diff --git a/runner/docs/run-and-deploy.md b/runner/docs/run-and-deploy.md index 2110d34e0..e4a666a77 100644 --- a/runner/docs/run-and-deploy.md +++ b/runner/docs/run-and-deploy.md @@ -742,7 +742,7 @@ own stdout — `wrangler deploy` prints a trailing `Current Version ID: ` line; capture it with `pnpm run deploy | tee deploy.log` (`set -o pipefail` is on, so a piped deploy failure still fails the job) and `grep -oE 'Current Version ID:.*' deploy.log | awk '{print $NF}'`. **This step -never fails the job on its own** (`-f` fails the curl on a non-2xx exit, but +never fails the job on its own** (the route answers `204` on success, and the warning fires for any other code; `-f` fails the curl on a non-2xx exit, but its own exit code is deliberately not checked with `set -e` in force — a warning line is emitted instead): a deploy that shipped correctly must not be marked red because the *reporting* of it hiccuped, and on the very first