From ccc49e8257ce45ba074448f6cc9a8992be058061 Mon Sep 17 00:00:00 2001 From: Pablo Deputter Date: Fri, 25 Sep 2026 12:19:19 +0200 Subject: [PATCH] tests(pyreqwuest): Drop `send_default_pii` support in tests --- .../integrations/pyreqwest/test_pyreqwest.py | 20 ++++++------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/tests/integrations/pyreqwest/test_pyreqwest.py b/tests/integrations/pyreqwest/test_pyreqwest.py index 0a448eb0a8..eccbedaaf8 100644 --- a/tests/integrations/pyreqwest/test_pyreqwest.py +++ b/tests/integrations/pyreqwest/test_pyreqwest.py @@ -594,12 +594,10 @@ def fake_start_span(*args, **kwargs): assert SPANDATA.CODE_FUNCTION in data -@pytest.mark.parametrize("send_default_pii", [True, False]) def test_crumb_capture( sentry_init, capture_events, server_port, - send_default_pii, ): def before_breadcrumb(crumb, hint): crumb["data"]["extra"] = "foo" @@ -608,7 +606,6 @@ def before_breadcrumb(crumb, hint): sentry_init( integrations=[PyreqwestIntegration()], before_breadcrumb=before_breadcrumb, - send_default_pii=send_default_pii, data_collection={}, ) @@ -633,25 +630,21 @@ def before_breadcrumb(crumb, hint): SPANDATA.HTTP_STATUS_CODE: 200, "extra": "foo", } - if send_default_pii: - expected["url"] = f"http://localhost:{server_port}/hello?q=test#frag" - expected[SPANDATA.HTTP_QUERY] = "q=test" - expected[SPANDATA.HTTP_FRAGMENT] = "frag" + expected["url"] = f"http://localhost:{server_port}/hello?q=test#frag" + expected[SPANDATA.HTTP_QUERY] = "q=test" + expected[SPANDATA.HTTP_FRAGMENT] = "frag" assert crumb["data"] == ApproxDict(expected) @pytest.mark.asyncio -@pytest.mark.parametrize("send_default_pii", [True, False]) async def test_async_crumb_capture( sentry_init, capture_events, server_port, - send_default_pii, ): sentry_init( integrations=[PyreqwestIntegration()], - send_default_pii=send_default_pii, data_collection={}, ) @@ -676,10 +669,9 @@ async def test_async_crumb_capture( SPANDATA.HTTP_METHOD: "GET", SPANDATA.HTTP_STATUS_CODE: 200, } - if send_default_pii: - expected["url"] = f"http://localhost:{server_port}/hello?q=test#frag" - expected[SPANDATA.HTTP_QUERY] = "q=test" - expected[SPANDATA.HTTP_FRAGMENT] = "frag" + expected["url"] = f"http://localhost:{server_port}/hello?q=test#frag" + expected[SPANDATA.HTTP_QUERY] = "q=test" + expected[SPANDATA.HTTP_FRAGMENT] = "frag" assert crumb["data"] == ApproxDict(expected)