Repository navigation
Commit dc803d2
committed
feat(android): Improve SentryNavEffect by consolidating back stack route mapping (JAVA-274)
Commit improves the yet-to-be-released SentryNavEffect by replacing separate route name and argument extractors with a single BackStackEntryMapper. Doing so lets us spare users from having to create three giant `when` statements mapping all nav entries in their entire app (two for us and one for Nav3's entryProvider). After this commit, users only have to create two. (Future work will allow them to create just one via a forthcoming Sentry entryProvider wrapper.)
Commit also uses the term "back stack entry" rather than "back stack route" throughout to avoid developer confusion, given Google's use of "route" to mean (essentially) a navigation destination. By contrast, we need a term that refers solely to an element in the host app's back stack. (In general, Nav3 is careful to distinguish between nav destinations and back stack entries, as a destination may be composed from multiple entries in a back stack.)1 parent d0843a2 commit dc803d2
16 files changed
Lines changed: 1415 additions & 1256 deletions
File tree
Lines changed: 14 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
1 | 5 | | |
2 | 6 | | |
3 | 7 | | |
| |||
6 | 10 | | |
7 | 11 | | |
8 | 12 | | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
15 | 22 | | |
16 | 23 | | |
17 | 24 | | |
18 | | - | |
| 25 | + | |
19 | 26 | | |
20 | 27 | | |
21 | 28 | | |
| |||
0 commit comments