Skip to content

Commit 9dcd252

Browse files
committed
Fix unit tests
1 parent 7cacdbb commit 9dcd252

2 files changed

Lines changed: 14 additions & 14 deletions

File tree

‎sentry-android-navigation3/src/test/kotlin/io/sentry/compose/navigation3/BackStackObserverTest.kt‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -337,14 +337,14 @@ class BackStackObserverTest {
337337
config = ObserverConfig(captureBackStack = true, maxCapturedBackStackEntries = 0)
338338
)
339339
fixture.scope.setContexts(
340-
"navigation",
341-
mapOf("backstack" to listOf(mapOf("entry" to "/Stale"))),
340+
NAVIGATION_CONTEXT_KEY,
341+
mapOf(BACKSTACK_KEY to listOf(mapOf("entry" to "/Stale"))),
342342
)
343343

344344
sut.onBackStackChanged(listOf(HomeScreen()))
345345

346346
// Doesn't emit a back stack...
347-
assertThat(fixture.scope.contexts.containsKey("navigation")).isFalse()
347+
assertThat(fixture.scope.contexts.containsKey(NAVIGATION_CONTEXT_KEY)).isFalse()
348348

349349
// ...but continues to emit all other Sentry data.
350350
assertThat(fixture.breadcrumbs.single().data["to"]).isEqualTo("/HomeScreen")
@@ -358,14 +358,14 @@ class BackStackObserverTest {
358358
val fixture = Fixture()
359359
val sut = fixture.getSut(config = ObserverConfig(captureBackStack = false))
360360
fixture.scope.setContexts(
361-
"navigation",
362-
mapOf("backstack" to listOf(mapOf("entry" to "/Stale"))),
361+
NAVIGATION_CONTEXT_KEY,
362+
mapOf(BACKSTACK_KEY to listOf(mapOf("entry" to "/Stale"))),
363363
)
364364

365365
sut.onBackStackChanged(listOf(HomeScreen()))
366366

367367
// Doesn't emit a back stack...
368-
assertThat(fixture.scope.contexts.containsKey("navigation")).isFalse()
368+
assertThat(fixture.scope.contexts.containsKey(NAVIGATION_CONTEXT_KEY)).isFalse()
369369

370370
// ...but continues to emit all other Sentry data.
371371
assertThat(fixture.breadcrumbs.single().data["to"]).isEqualTo("/HomeScreen")
@@ -606,7 +606,7 @@ class BackStackObserverTest {
606606
assertThat(fixture.scope.transaction).isNull()
607607
assertThat(fixture.scope.screen).isNull()
608608
assertThat(fixture.scope.contexts.app?.viewNames).isNull()
609-
assertThat(fixture.scope.contexts.containsKey("navigation")).isFalse()
609+
assertThat(fixture.scope.contexts.containsKey(NAVIGATION_CONTEXT_KEY)).isFalse()
610610
assertThat(fixture.breadcrumbs).hasSize(1)
611611
}
612612

@@ -754,7 +754,7 @@ class BackStackObserverTest {
754754
assertThat(fixture.scope.transaction).isNull()
755755
assertThat(fixture.scope.screen).isNull()
756756
assertThat(fixture.scope.contexts.app?.viewNames).isNull()
757-
assertThat(fixture.scope.contexts.containsKey("navigation")).isFalse()
757+
assertThat(fixture.scope.contexts.containsKey(NAVIGATION_CONTEXT_KEY)).isFalse()
758758
}
759759

760760
private fun IScope.navigationBackStack(): List<Map<String, Any?>>? {
@@ -772,7 +772,7 @@ class BackStackObserverTest {
772772
}
773773

774774
private companion object {
775-
const val NAVIGATION_CONTEXT_KEY = "navigation"
776-
const val BACKSTACK_KEY = "backstack"
775+
const val NAVIGATION_CONTEXT_KEY = "Navigation"
776+
const val BACKSTACK_KEY = "Back Stack"
777777
}
778778
}

‎sentry-android-navigation3/src/test/kotlin/io/sentry/compose/navigation3/SentryNavEffectTest.kt‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -510,7 +510,7 @@ class SentryNavEffectTest {
510510
assertThat(fixture.transactions.last().isFinished).isFalse()
511511
assertThat(fixture.scope.transaction).isSameInstanceAs(fixture.transactions.last())
512512
assertThat(fixture.scope.screen).isEqualTo("/HomeRoute")
513-
assertThat(fixture.scope.contexts.containsKey("navigation")).isFalse()
513+
assertThat(fixture.scope.contexts.containsKey(NAVIGATION_CONTEXT_KEY)).isFalse()
514514
}
515515

516516
@Test
@@ -539,7 +539,7 @@ class SentryNavEffectTest {
539539
assertThat(fixture.scope.transaction).isNull()
540540
assertThat(fixture.scope.screen).isNull()
541541
assertThat(fixture.scope.contexts.app?.viewNames).isNull()
542-
assertThat(fixture.scope.contexts.containsKey("navigation")).isFalse()
542+
assertThat(fixture.scope.contexts.containsKey(NAVIGATION_CONTEXT_KEY)).isFalse()
543543
}
544544

545545
private fun IScope.navigationBackStack(): List<Map<String, Any?>>? {
@@ -557,7 +557,7 @@ class SentryNavEffectTest {
557557
}
558558

559559
private companion object {
560-
const val NAVIGATION_CONTEXT_KEY = "navigation"
561-
const val BACKSTACK_KEY = "backstack"
560+
const val NAVIGATION_CONTEXT_KEY = "Navigation"
561+
const val BACKSTACK_KEY = "Back Stack"
562562
}
563563
}

0 commit comments

Comments
 (0)