ref(core): Remove legacy Metrics warning inputs

Remove obsolete external and Android manifest parsing retained only for
migration warnings that will not ship in v9.

Co-Authored-By: Claude <noreply@anthropic.com>

Author: adinauer

sentry-android-core/src/main/java/io/sentry/android/core/ManifestMetadataReader.java

@@ -196,8 +196,6 @@ final class ManifestMetadataReader {
 
   static final String ENABLE_LOGCAT_LOGS = "io.sentry.logcat.logs.enabled";
 
-  static final String ENABLE_METRICS = "io.sentry.metrics.enabled";
-
   static final String ENABLE_AUTO_TRACE_ID_GENERATION =
       "io.sentry.traces.enable-auto-id-generation";
 

sentry-android-core/src/test/java/io/sentry/android/core/ManifestMetadataReaderTest.kt

@@ -13,8 +13,6 @@ import io.sentry.ProfileLifecycle
 import io.sentry.SentryLevel
 import io.sentry.SentryReplayOptions
 import io.sentry.TransactionOptions
-import io.sentry.test.createSentryClientMock
-import io.sentry.test.createTestScopes
 import kotlin.test.AfterTest
 import kotlin.test.BeforeTest
 import kotlin.test.Test
@@ -25,7 +23,6 @@ import kotlin.test.assertNull
 import kotlin.test.assertTrue
 import org.junit.runner.RunWith
 import org.mockito.kotlin.any
-import org.mockito.kotlin.anyOrNull
 import org.mockito.kotlin.eq
 import org.mockito.kotlin.mock
 import org.mockito.kotlin.never
@@ -2227,20 +2224,6 @@ class ManifestMetadataReaderTest {
     assertThat(fixture.options.isEnableLogcatLogs).isFalse()
   }
 
-  @Test
-  fun `legacy metrics metadata does not disable capture`() {
-    val bundle = bundleOf(ManifestMetadataReader.ENABLE_METRICS to false)
-    val context = fixture.getContext(metaData = bundle)
-    val client = createSentryClientMock()
-
-    ManifestMetadataReader.applyMetadata(context, fixture.options, fixture.buildInfoProvider)
-    fixture.options.dsn = "https://key@sentry.io/proj"
-    val scopes = createTestScopes(fixture.options).also { it.bindClient(client) }
-    scopes.metrics().count("metric name")
-
-    verify(client).captureMetric(any(), anyOrNull(), anyOrNull())
-  }
-
   @Test
   fun `applyMetadata reads feedback name required and keep default value if not found`() {
     // Arrange

sentry/api/sentry.api

@@ -590,7 +590,6 @@ public final class io/sentry/ExternalOptions {
 	public fun isEnableBackpressureHandling ()Ljava/lang/Boolean;
 	public fun isEnableCacheTracing ()Ljava/lang/Boolean;
 	public fun isEnableDatabaseTransactionTracing ()Ljava/lang/Boolean;
-	public fun isEnableMetrics ()Ljava/lang/Boolean;
 	public fun isEnablePrettySerializationOutput ()Ljava/lang/Boolean;
 	public fun isEnableQueueTracing ()Ljava/lang/Boolean;
 	public fun isEnableSpotlight ()Ljava/lang/Boolean;
@@ -610,7 +609,6 @@ public final class io/sentry/ExternalOptions {
 	public fun setEnableCacheTracing (Ljava/lang/Boolean;)V
 	public fun setEnableDatabaseTransactionTracing (Ljava/lang/Boolean;)V
 	public fun setEnableDeduplication (Ljava/lang/Boolean;)V
-	public fun setEnableMetrics (Ljava/lang/Boolean;)V
 	public fun setEnablePrettySerializationOutput (Ljava/lang/Boolean;)V
 	public fun setEnableQueueTracing (Ljava/lang/Boolean;)V
 	public fun setEnableSpotlight (Ljava/lang/Boolean;)V

sentry/src/main/java/io/sentry/ExternalOptions.java

@@ -46,7 +46,6 @@ public final class ExternalOptions {
   private @Nullable Boolean enabled;
   private @Nullable Boolean enablePrettySerializationOutput;
   private @Nullable Boolean enableSpotlight;
-  private @Nullable Boolean enableMetrics;
   private @Nullable String spotlightConnectionUrl;
 
   private @Nullable List<String> ignoredCheckIns;
@@ -177,8 +176,6 @@ public final class ExternalOptions {
     options.setCaptureOpenTelemetryEvents(
         propertiesProvider.getBooleanProperty("capture-open-telemetry-events"));
 
-    options.setEnableMetrics(propertiesProvider.getBooleanProperty("metrics.enabled"));
-
     for (final String ignoredExceptionType :
         propertiesProvider.getList("ignored-exceptions-for-type")) {
       try {
@@ -714,14 +711,6 @@ public void setCaptureOpenTelemetryEvents(final @Nullable Boolean captureOpenTel
     return captureOpenTelemetryEvents;
   }
 
-  public void setEnableMetrics(final @Nullable Boolean enableMetrics) {
-    this.enableMetrics = enableMetrics;
-  }
-
-  public @Nullable Boolean isEnableMetrics() {
-    return enableMetrics;
-  }
-
   public @Nullable Double getProfileSessionSampleRate() {
     return profileSessionSampleRate;
   }

sentry/src/test/java/io/sentry/ExternalOptionsTest.kt

@@ -530,25 +530,6 @@ class ExternalOptionsTest {
     }
   }
 
-  @Test
-  fun `creates options with enableMetrics set to true`() {
-    withPropertiesFile("metrics.enabled=true") { options ->
-      assertTrue(options.isEnableMetrics == true)
-    }
-  }
-
-  @Test
-  fun `creates options with enableMetrics set to false`() {
-    withPropertiesFile("metrics.enabled=false") { options ->
-      assertTrue(options.isEnableMetrics == false)
-    }
-  }
-
-  @Test
-  fun `creates options with enableMetrics set to null when not set`() {
-    withPropertiesFile { assertNull(it.isEnableMetrics) }
-  }
-
   @Test
   fun `creates options with profileSessionSampleRate set to 0_8`() {
     withPropertiesFile("profile-session-sample-rate=0.8") { options ->

sentry/src/test/java/io/sentry/ScopesTest.kt

@@ -3300,18 +3300,6 @@ class ScopesTest {
     verify(mockClient, never()).captureMetric(any(), anyOrNull(), anyOrNull())
   }
 
-  @Test
-  fun `legacy external metrics configuration does not disable capture`() {
-    val (sut, mockClient) =
-      getEnabledScopes { options ->
-        options.merge(ExternalOptions().also { it.isEnableMetrics = false })
-      }
-
-    sut.metrics().count("metric name")
-
-    verify(mockClient).captureMetric(any(), anyOrNull(), anyOrNull())
-  }
-
   @Test
   fun `creating count metric works`() {
     val (sut, mockClient) = getEnabledScopes()

sentry/src/test/java/io/sentry/SentryOptionsTest.kt

@@ -579,7 +579,6 @@ class SentryOptionsTest {
     externalOptions.isEnableSpotlight = true
     externalOptions.spotlightConnectionUrl = "http://local.sentry.io:1234"
     externalOptions.isGlobalHubMode = true
-    externalOptions.isEnableMetrics = false
     externalOptions.profileSessionSampleRate = 0.8
     externalOptions.profilingTracesDirPath = "/profiling-traces"
     externalOptions.profileLifecycle = ProfileLifecycle.TRACE