Skip to content

Commit 2d5188e

Browse files
buenaflorclaude
andcommitted
chore(extend-app-start): Trim finishTransaction/getExtendedEndTime comments
Drop finishTransaction's javadoc (trivial body; it described caller context and waitForChildren behavior configured elsewhere) and reduce getExtendedEndTime's javadoc to a single inline note on the only non-obvious branch (deadline suppression). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 4a97d27 commit 2d5188e

1 file changed

Lines changed: 2 additions & 10 deletions

File tree

‎sentry-android-core/src/main/java/io/sentry/android/core/AppStartExtension.java‎

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -109,11 +109,6 @@ public boolean isActive() {
109109
}
110110
}
111111

112-
/**
113-
* Finishes the owned transaction at the natural app start end (first frame, or the headless stop
114-
* time). {@code waitForChildren} holds the transaction open until the extended span finishes, so
115-
* the app start vital is never captured before this point. Idempotent.
116-
*/
117112
public void finishTransaction(final @NotNull SentryDate endTimestamp) {
118113
try (final @NotNull ISentryLifecycleToken ignored = lock.acquire()) {
119114
final @Nullable ITransaction transaction = extendedTransaction;
@@ -123,17 +118,14 @@ public void finishTransaction(final @NotNull SentryDate endTimestamp) {
123118
}
124119
}
125120

126-
/**
127-
* The effective end of the extended app start, used to extend the app start vital. Returns {@code
128-
* null} when no extension finished, or when it finished via the deadline timeout - in the latter
129-
* case the vital is suppressed instead of reporting an artificially inflated duration.
130-
*/
131121
public @Nullable SentryDate getExtendedEndTime() {
132122
try (final @NotNull ISentryLifecycleToken ignored = lock.acquire()) {
133123
final @Nullable ISpan span = extendedSpan;
134124
if (span == null || !span.isFinished()) {
135125
return null;
136126
}
127+
// A deadline timeout would report an artificially inflated duration; suppress the vital
128+
// instead.
137129
if (span.getStatus() == SpanStatus.DEADLINE_EXCEEDED) {
138130
return null;
139131
}

0 commit comments

Comments
 (0)