fix(nav3): Remove unverifiable Nav3 timing metrics

Author: 0xadam-brown

sentry-samples/sentry-samples-android/src/main/java/io/sentry/samples/android/navigation/nav3/Nav3Activity.kt

@@ -296,30 +296,22 @@ private fun Nav3SampleApp(
       controller = customTransactionController,
     )
 
-    val extractorNanosBefore =
-      performanceState.nameExtractorNanos + performanceState.argumentsExtractorNanos
-    val startedAtNanos = System.nanoTime()
-
     SentryNavEffect(
       backStack = sentryBackStack,
       backStackEntryMapper = backStackEntryMapper,
       options = sentryNavOptions,
     )
 
     if (isPerformanceScenario) {
-      SideEffect {
-        performanceState.recordSentryNavEffect(
-          durationNanos = System.nanoTime() - startedAtNanos,
-          extractorNanosBefore = extractorNanosBefore,
-          processedCall = true,
-          resolvedEntryCount =
-            if (integrationMode.captureBackStack) {
-              minOf(sentryBackStack.size, maxCapturedBackStackEntries)
-            } else {
-              0
-            },
-        )
-      }
+      performanceState.recordSentryNavEffect(
+        processedCall = true,
+        resolvedEntryCount =
+          if (integrationMode.captureBackStack) {
+            minOf(sentryBackStack.size, maxCapturedBackStackEntries)
+          } else {
+            0
+          },
+      )
     }
   }
 

sentry-samples/sentry-samples-android/src/main/java/io/sentry/samples/android/navigation/nav3/Nav3PerformanceControls.kt

@@ -97,8 +97,6 @@ internal class Nav3PerformanceState(
   var capturedEntriesResolved = 0
     private set
 
-  private val sentryNavEffectDurations = Nav3PerformanceDurations()
-  private val extractorDurations = Nav3PerformanceDurations()
   private val mutationToCompositionDurations = Nav3PerformanceDurations()
   private val mutationToFirstDrawDurations = Nav3PerformanceDurations()
   private var pendingOperation: PendingNav3PerformanceOperation? = null
@@ -123,8 +121,6 @@ internal class Nav3PerformanceState(
     sentryNavEffectAttempts = 0
     sentryNavEffectProcessedCalls = 0
     capturedEntriesResolved = 0
-    sentryNavEffectDurations.clear()
-    extractorDurations.clear()
     mutationToCompositionDurations.clear()
     mutationToFirstDrawDurations.clear()
     comparisonResult = null
@@ -239,8 +235,6 @@ internal class Nav3PerformanceState(
   }
 
   fun recordSentryNavEffect(
-    durationNanos: Long,
-    extractorNanosBefore: Long,
     processedCall: Boolean,
     resolvedEntryCount: Int,
   ) {
@@ -259,8 +253,6 @@ internal class Nav3PerformanceState(
       capturedEntriesResolved += resolvedEntryCount
     }
     pendingProcessedNavigationWork = false
-    sentryNavEffectDurations.add(durationNanos)
-    extractorDurations.add(nameExtractorNanos + argumentsExtractorNanos - extractorNanosBefore)
   }
 
   fun startPerformanceRun(status: String) {
@@ -319,8 +311,7 @@ internal class Nav3PerformanceState(
   }
 
   fun performanceSummary(label: String): String =
-    "$label: effect ${sentryNavEffectDurations.compactSummary()}, " +
-      "first draw ${mutationToFirstDrawDurations.compactSummary()}"
+    "$label: first draw ${mutationToFirstDrawDurations.compactSummary()}"
 
   fun diagnosticsSummary(currentRoute: String, backStack: String): String = buildString {
     appendLine("status=$performanceStatus")
@@ -336,9 +327,6 @@ internal class Nav3PerformanceState(
     appendLine("arguments_extractor_calls=$argumentsExtractorCalls")
     appendLine("name_extractor_avg=${nameExtractorAverageMicros()}")
     appendLine("arguments_extractor_avg=${argumentsExtractorAverageMicros()}")
-    appendLine("sentry_nav_effect_duration=${sentryNavEffectDurationSummary()}")
-    appendLine("extractor_duration=${extractorDurationSummary()}")
-    appendLine("non_extractor_estimate=${nonExtractorDurationSummary()}")
     appendLine("mutation_to_composition=${mutationToCompositionSummary()}")
     appendLine("mutation_to_first_draw=${mutationToFirstDrawSummary()}")
     appendLine("first_draws_over_8_3_ms=${firstDrawsOver8Millis()}")
@@ -391,13 +379,6 @@ internal class Nav3PerformanceState(
     pendingMeasuredPhase = null
   }
 
-  fun sentryNavEffectDurationSummary(): String = sentryNavEffectDurations.summary()
-
-  fun extractorDurationSummary(): String = extractorDurations.summary()
-
-  fun nonExtractorDurationSummary(): String =
-    sentryNavEffectDurations.minus(extractorDurations).summary()
-
   fun mutationToCompositionSummary(): String = mutationToCompositionDurations.summary()
 
   fun mutationToFirstDrawSummary(): String = mutationToFirstDrawDurations.summary()
@@ -954,21 +935,6 @@ internal fun Nav3PerformancePanel(
             state.argumentsExtractorAverageMicros(),
             tag = navPerformanceTag("arguments_extractor_avg"),
           )
-          PerfInfoRow(
-            "SentryNavEffect duration",
-            state.sentryNavEffectDurationSummary(),
-            tag = navPerformanceTag("sentry_nav_effect_duration"),
-          )
-          PerfInfoRow(
-            "Extractor duration",
-            state.extractorDurationSummary(),
-            tag = navPerformanceTag("extractor_duration"),
-          )
-          PerfInfoRow(
-            "Non-extractor estimate",
-            state.nonExtractorDurationSummary(),
-            tag = navPerformanceTag("non_extractor_estimate"),
-          )
           PerfInfoRow(
             "Mutation to composition",
             state.mutationToCompositionSummary(),