From 7e600f4f9379a27a58b843b6de376f66888feb64 Mon Sep 17 00:00:00 2001 From: meodiemvuong1609 <125726991+meodiemvuong1609@users.noreply.github.com> Date: Tue, 3 Nov 2026 01:54:15 +0300 Subject: [PATCH] =?UTF-8?q?fix(loop):=20CB=5FAUTO=5FRESET=20v=C3=A0=20CB?= =?UTF-8?q?=5FCOOLDOWN=5FMINUTES=20trong=20.ralphrc=20b=E1=BB=8B=20b?= =?UTF-8?q?=E1=BB=8F=20qua?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Snapshot _env_ của hai khoá này nằm sau khối source lib, mà lib/circuit_breaker.sh gán mặc định (false, 30) lúc source. Snapshot vì thế ghi nhận mặc định như giá trị env và đè lên .ralphrc: CB_AUTO_RESET=true không bao giờ có tác dụng, circuit breaker OPEN phải chờ cooldown thay vì tự reset khi khởi động. Chuyển hai dòng vào khối snapshot trước source (#369) và thêm chúng vào bảng test dùng ralph_loop.sh thật. Co-Authored-By: Claude Opus 5.5 --- ralph_loop.sh | 4 ++-- tests/unit/test_ralphrc_security.bats | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/ralph_loop.sh b/ralph_loop.sh index e5771e19..7910820d 100755 --- a/ralph_loop.sh +++ b/ralph_loop.sh @@ -37,6 +37,8 @@ _env_CB_NO_PROGRESS_THRESHOLD="${CB_NO_PROGRESS_THRESHOLD:-}" _env_CB_SAME_ERROR_THRESHOLD="${CB_SAME_ERROR_THRESHOLD:-}" _env_CB_OUTPUT_DECLINE_THRESHOLD="${CB_OUTPUT_DECLINE_THRESHOLD:-}" _env_CB_PERMISSION_DENIAL_THRESHOLD="${CB_PERMISSION_DENIAL_THRESHOLD:-}" +_env_CB_COOLDOWN_MINUTES="${CB_COOLDOWN_MINUTES:-}" +_env_CB_AUTO_RESET="${CB_AUTO_RESET:-}" # Source library components SCRIPT_DIR="$(dirname "${BASH_SOURCE[0]}")" @@ -79,8 +81,6 @@ _env_CLAUDE_ALLOWED_TOOLS="${CLAUDE_ALLOWED_TOOLS:-}" _env_CLAUDE_USE_CONTINUE="${CLAUDE_USE_CONTINUE:-}" _env_CLAUDE_SESSION_EXPIRY_HOURS="${CLAUDE_SESSION_EXPIRY_HOURS:-}" _env_VERBOSE_PROGRESS="${VERBOSE_PROGRESS:-}" -_env_CB_COOLDOWN_MINUTES="${CB_COOLDOWN_MINUTES:-}" -_env_CB_AUTO_RESET="${CB_AUTO_RESET:-}" _env_CLAUDE_CODE_CMD="${CLAUDE_CODE_CMD:-}" _env_CLAUDE_AUTO_UPDATE="${CLAUDE_AUTO_UPDATE:-}" _env_CLAUDE_MODEL="${CLAUDE_MODEL:-}" diff --git a/tests/unit/test_ralphrc_security.bats b/tests/unit/test_ralphrc_security.bats index 43efdb8d..f71a07ec 100644 --- a/tests/unit/test_ralphrc_security.bats +++ b/tests/unit/test_ralphrc_security.bats @@ -545,6 +545,8 @@ CB_NO_PROGRESS_THRESHOLD 3 1 10 CB_SAME_ERROR_THRESHOLD 5 1 11 CB_OUTPUT_DECLINE_THRESHOLD 70 1 12 CB_PERMISSION_DENIAL_THRESHOLD 2 1 13 +CB_COOLDOWN_MINUTES 30 1 17 +CB_AUTO_RESET false true false MAX_CONSECUTIVE_TEST_LOOPS 3 1 14 MAX_CONSECUTIVE_DONE_SIGNALS 2 1 15 TEST_PERCENTAGE_THRESHOLD 30 1 16