Panic "`"config_values"` is not an id of an argument or a group."

[lf-]

I ran:

$ cargo run -p buck2 -- expand-external-cell buck2-haskell
     Running `target/debug/buck2 expand-external-cell buck2-haskell`

thread 'buck2-main' (754047) panicked at app/buck2_client_ctx/src/common.rs:264:41:
`"config_values"` is not an id of an argument or a group.
Make sure you're using the name of the argument itself and not the name of short or long flags.
stack backtrace:
   0: __rustc::rust_begin_unwind
             at /rustc/fe98ddcfcfb6f185dbf4adeaf439d8a756da0273/library/std/src/panicking.rs:689:5
   1: core::panicking::panic_fmt
             at /rustc/fe98ddcfcfb6f185dbf4adeaf439d8a756da0273/library/core/src/panicking.rs:80:14
   2: <clap_builder::parser::matches::arg_matches::ArgMatches>::get_arg
             at /Users/jade/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/clap_builder-4.5.60/src/parser/matches/arg_mat
ches.rs:1324:17
   3: <clap_builder::parser::matches::arg_matches::ArgMatches>::indices_of
             at /Users/jade/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/clap_builder-4.5.60/src/parser/matches/arg_mat
ches.rs:856:30
   4: <buck2_client_ctx::common::CommonBuildConfigurationOptions>::config_overrides::with_indices::<alloc::string::String>
             at ./app/buck2_client_ctx/src/common.rs:264:41
   5: <buck2_client_ctx::common::CommonBuildConfigurationOptions>::config_overrides
             at ./app/buck2_client_ctx/src/common.rs:274:34
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
zsh: abort      cargo r -p buck2 -- expand-external-cell buck2-haskell

This seems to make the OSS build less usable than ideal. I bet it vanishes in release builds which might be why nobody noticed before.

buckconfig.local in the buck2 repo:

[cells]
buck2-haskell = buck2-haskell

[external_cells]
buck2-haskell = git

[external_cell_buck2-haskell]
git_origin = https://github.com/MercuryTechnologies/buck2-haskell.git
# branch: experiments
commit_hash = cf63dfaf6dd0c29aa66e00987bfa3f27f1add5f4

[cormacrelf]

It does vanish in release builds. https://docs.rs/clap/latest/clap/struct.ArgMatches.html#method.indices_of

Panics

If id is not a valid argument or group id (debug builds).

The cause is that expand-external cell command does not have CommonBuildConfigurationOptions, which is the thing with the config_values arg, so "config_values" is not a valid arg id in expand-external-cell.