Kinda broken with gtk 4.21

[garaevdi]

Not sure about this existing as an issue. I noticed other issues regarding animated icons in granite repo and gtk 4.22 not being out yet but anyway...

Some icons aren't rendering with gtk 4.21.5 and sometimes this could lead to an app crashing.

Steps to reproduce

Broken icons

1. Install org.gnome.design.IconLibrary from gnome-nightly flatpak repo
2. Some icons are missing

App crash

1. Install org.gnome.Nautilus from gnome-nightly flatpak repo
2. It crashes trying to load icons for non-folder files (I guess)

Tested on a fedora 43 and elementary 8, but most noticeable on a fedora 44

[danirabbit]

We provide icons covering the freedesktop icon spec here. If GNOME apps have missing icons or are crashing this needs to be reported against those apps. It's app developers responsibility to make sure that their apps bundle the necessary assets outside of the fd.o spec

[garaevdi]

Sorry, I guess I didn't explained the issue I was dealing with well enough.

Initially I stumbled upon this when testing gala for fedora 44. Monitor wouldn't start. Gdb backtraces showed nothing wrong with the monitor itself, whole callstack was full of gtk internal logic regarding svg loading, so I dismissed it as a possible prerelase gtk bug. Later I noticed that some icons here and there in elementary apps were missing. The most noticeable one is list-add-symbolic as it used in a lot of places. All that rung a bell, that the issue might due to changes in a gtk svg rendering. So I tested monitor with Adwaita icon theme and it worked like a charm, no more crashes.

Those examples include gnome apps so that everyone can test this, since AFAIK only apps from gnome-nightly flatpak repo use latest gtk at the moment and both of those apps use system installed icons. With gtk 4.21 installed as a system library every gtk app show those symptoms, even elementary ones.

Some screenshots

Appcenter on fedora 44 and on fedora 43 (Don't look at an app icon, it's just my internet being funky)

Icon library from flathub (gtk 4.20) and gnome-nightly (gtk 4.21) showing approximately the same view

Keyboard settings missing a plus icon next to "Add keyboard layout" text

Monitor backtrace

Thread 7 "pool-0" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffe37fe6c0 (LWP 30615)]
0x00007ffff6f0a4e2 in g_atomic_ref_count_dec (arc=arc@entry=0x8) at ../glib/grefcount.c:247
247	  old_value = g_atomic_int_add (arc, -1);
(gdb) bt
#0  0x00007ffff6f0a4e2 in g_atomic_ref_count_dec (arc=arc@entry=0x8) at ../glib/grefcount.c:247
#1  0x00007ffff73e5f34 in _gsk_render_node_unref (node=0x0) at ../gsk/gskrendernode.c:327
#2  stroke_shape (shape=<optimized out>, path=<optimized out>, context=0x7fffe37fcf70)
    at ../gtk/gtksvg.c:21335
#3  0x00007ffff73ed841 in paint_shape (shape=0x7fffd8032440, context=0x7fffe37fcf70)
    at ../gtk/gtksvg.c:22322
#4  render_shape (shape=0x7fffd8032440, context=<optimized out>) at ../gtk/gtksvg.c:22410
#5  0x00007ffff73ebfe3 in paint_shape (shape=0x7fffd800e170, context=0x7fffe37fcf70)
    at ../gtk/gtksvg.c:22256
#6  render_shape (shape=0x7fffd800e170, context=<optimized out>) at ../gtk/gtksvg.c:22410
#7  0x00007ffff73eddd6 in gtk_svg_snapshot_with_weight
    (paintable=0x7fffd8007250, snapshot=0x7fffd803b570, width=<optimized out>, height=<optimized out>, colors=0x7fffe37fd090, n_colors=5, weight=<optimized out>) at ../gtk/gtksvg.c:22572
#8  0x00007ffff73f6518 in gtk_symbolic_paintable_snapshot_symbolic
    (paintable=0x7fffd8007250, snapshot=0x7fffd803b570, width=64, height=64, colors=<optimized out>, n_colors=<optimized out>) at ../gtk/gtksymbolicpaintable.c:135
#9  0x00007ffff7493729 in svg_to_texture
    (svg=svg@entry=0x7fffd8007250, width=width@entry=64, height=height@entry=64, colors=colors@entry=0x0, n_colors=n_colors@entry=0) at ../gtk/gdktextureutils.c:52
#10 0x00007ffff7493815 in gdk_texture_new_from_stream_at_scale.constprop.0
    (stream=stream@entry=0x7fffd800ece0, width=width@entry=64, height=height@entry=64, only_fg=only_fg@entry=0x7fffe37fd1e4, error=error@entry=0x7fffe37fd1e8, cancellable=0x0) at ../gtk/gdktextureutils.c:466
#11 0x00007ffff72f0e1f in icon_ensure_node__locked
    (icon=icon@entry=0x55555994e600, in_thread=in_thread@entry=1) at ../gtk/gtkiconpaintable.c:199
#12 0x00007ffff72f1130 in gtk_icon_paintable_load_in_thread (self=0x55555994e600)
    at ../gtk/gtkiconpaintable.c:694
#13 load_icon_thread
    (task=0x5555599593e0, source_object=0x55555994e600, task_data=<optimized out>, cancellable=<optimized out>) at ../gtk/gtkicontheme.c:2292
#14 0x00007ffff709a99e in g_task_thread_pool_thread (thread_data=0x5555599593e0, pool_data=<optimized out>)
    at ../gio/gtask.c:1585
#15 0x00007ffff6f3057a in g_thread_pool_thread_proxy (data=<optimized out>) at ../glib/gthreadpool.c:336
#16 0x00007ffff6f2e7d2 in g_thread_proxy (data=0x7fffd4000b80) at ../glib/gthread.c:893
#17 0x00007ffff67028d9 in start_thread (arg=<optimized out>) at pthread_create.c:454
#18 0x00007ffff6786bcc in __GI___clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:78

[danirabbit]

Ah this should probably be reported against GTK then since it would be considered a regression in GTK's icon renderer

[ali2027007-create]

#1417 (reply in thread)

[teamcons]

The related issue report against GTK: https://gitlab.gnome.org/GNOME/gtk/-/issues/8147

It is tracked for granite-based apps here: flathub/io.elementary.BaseApp#48

[ryonakano]

Closing the discussion as fixed in 9.0.0. Thank you very much again for your work @garaevdi!

[peteruithoven]

Thanks for fixing this in elementary OS 9, but is there a chance it could reach elementary OS 8 as well?
We won't have elementary OS 9 for a while (not complaining) and we will have a lot of apps that use the flatpak runtime GNOME 50 which uses GTK 4.22 with this regression.

For me personally it's happening in Convey, Flatseal, Mission Center, Resources just to name a couple. In a lot of cases buttons don't have a background so missing icons just leave an empty space, so it's not even clear you're missing anything.

For scale: in 8.2.0, 43 icons have a <g transform> and 329 have any transform.

GNOME 51 is out, but waiting for all these apps to upgrade to GNOME 51 doesn't seem reasonable? There will be a long tail of apps who won't update for a while.
The GNOME runtimes tent to only upgrade to bug fixes (GTK4 4.22.x), while the fix for this regression is in GTK 4.24?

I understand the elementary OS 9 icons have been simplified, see for example: #1421
Is there any change we can backport / cherry pick these simplifications to elementary OS 8?

Alternatively GTK would need to backport some kind of minimal fix to GTK 4.22 so that the GNOME 50 runtime can pick up this upgrade. See: https://gitlab.gnome.org/GNOME/gtk/-/work_items/8147#note_2883359.

[danirabbit]

It looks like the only removal we had for 9.0 was office-calendar. So I think we can pull the 9.0 release to the noble release branch and then revert that one removal and probably be okay to ship it

[ryonakano]

Leaving a note that backport for OS 8 was done in #1453. Thank you two for working on this.

[danirabbit]

@ryonakano we still need to make an actual release to stable though right?

[ryonakano]

Yes, you're right.

[peteruithoven]

Could someone have a look at the following backport?
It's been working well for me for the past few days.
#1452