Skip to content
This repository was archived by the owner on Dec 24, 2021. It is now read-only.
This repository was archived by the owner on Dec 24, 2021. It is now read-only.

Problems with the CommandDispatcher interface? #390

Description

@GreenCappuccino

The handleMessage method in CommandDispatcher is private. This doesn't seem to make sense?

handleMessage is called in the constructor of the Commando client, and nothing in CommandDispatcher actually calls it.

So, it seems like this should be a public method? I'm writing a child class in TypeScript of CommandDispatcher to intercept all messages, and this interface definition is causing problems.

Is there a design decision behind this, or should this be changed?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions