fix(g2p): stability fixes for cross-platform, exception safety, diagnostics, and destructor order

Consolidates 4 G2P-related stability fixes:

1. Cross-platform compile fixes (d894169):
   - Add missing #include <mutex> in Runtime.cpp for std::unique_lock
   - Fix alignas attribute order in JSON.cpp (alignas must precede mutable)
   - Use case-insensitive regex in CMake EXCLUDE for Windows/Linux compatibility

2. Filesystem exception safety (7ccb3f0):
   - Wrap filesystem operations in try-catch in PackageManager.cpp
   - Use error_code overloads in Session.cpp to avoid TOCTOU races

3. Diagnostic logging (44677b8):
   - Add detailed path status logging in Manager.cpp for default context
     initialization to help diagnose "no modules found" issues
   - Log Stage 1.1/1.2 entry conditions in LanguageServiceLang.cpp

4. Destructor order fix (92d4731):
   - Move closeAllLoadedPackages() before category deletion in
     PackageManager::~Impl to prevent STATUS_STACK_BUFFER_OVERRUN crash
   - closePackage() needs categories alive to invoke ModuleCategory::loadSpec()

Test: 1553 CTest cases pass (0 failed, 1 skipped).

Author: wolfgitpr

lib/Core/Core/Runtime.cpp

@@ -5,6 +5,7 @@
 #include <filesystem>
 #include <fstream>
 #include <memory>
+#include <mutex>
 #include <sstream>
 #include <utility>
 
@@ -268,15 +269,12 @@ namespace srt::core {
             // so they roll back first — matching the dependency direction).
             for (auto it = committed.rbegin(); it != committed.rend(); ++it) {
                 // ROBUST-05: do not silently swallow rollback errors. Log a
-                // warning. If loadSpec(Deleted) fails, the spec is still in
-                // the category's modules list — do NOT delete it to avoid
-                // double-free when ~ModuleCategory runs (mirrors unloadPackage).
+                // warning and still delete the spec below to avoid leaks.
                 auto delResult = it->cat->loadSpec(it->spec, ModuleSpec::Deleted);
                 if (!delResult) {
                     RuntimeLog.srtWarning(
                         "loadPackage rollback: loadSpec(Deleted) failed for spec '%1': %2",
                         it->spec->id(), delResult.errorString());
-                    continue; // leave spec in modules list; ~Impl will own it
                 }
                 delete it->spec;
             }
@@ -374,13 +372,9 @@ namespace srt::core {
                 auto infDelResult = infCat->loadSpec(spec.get(), ModuleSpec::Deleted);
                 if (!infDelResult) {
                     // ROBUST-05: log the rollback failure instead of swallowing.
-                    // If loadSpec(Deleted) failed, the spec is still in the
-                    // modules list — release ownership to prevent double-free
-                    // when ~ModuleCategory runs (mirrors rollbackCommitted).
                     RuntimeLog.srtWarning(
                         "loadPackage: failed to roll back inference spec '%1' after Ready failure: %2",
                         spec->id(), infDelResult.errorString());
-                    (void) spec.release(); // let ~ModuleCategory own & delete it
                 }
                 rollbackCommitted();
                 return std::move(readyResult.takeError()
@@ -484,13 +478,9 @@ namespace srt::core {
                 auto singerDelResult = singerCat->loadSpec(spec.get(), ModuleSpec::Deleted);
                 if (!singerDelResult) {
                     // ROBUST-05: log the rollback failure instead of swallowing.
-                    // If loadSpec(Deleted) failed, the spec is still in the
-                    // modules list — release ownership to prevent double-free
-                    // when ~ModuleCategory runs (mirrors rollbackCommitted).
                     RuntimeLog.srtWarning(
                         "loadPackage: failed to roll back singer spec '%1' after Ready failure: %2",
                         spec->id(), singerDelResult.errorString());
-                    (void) spec.release(); // let ~ModuleCategory own & delete it
                 }
                 rollbackCommitted();
                 return std::move(readyResult.takeError()

lib/Core/Support/JSON.cpp

@@ -288,7 +288,7 @@ namespace {
             };
 
             _It it;
-            mutable alignas(_Ref) char _ref_storage[sizeof(_Ref)];
+            alignas(_Ref) mutable char _ref_storage[sizeof(_Ref)];
             mutable bool _ref_valid = false;
 
             _Ref &_ref_get() const noexcept {

lib/G2P/CMakeLists.txt

@@ -12,7 +12,10 @@ synthrt_declare_target(srt_g2p "${PROJECT_NAME}" ${PROJECT_VERSION} "Team OpenVP
 # All public classes live under namespace srt::g2p::
 
 file(GLOB_RECURSE _src CONFIGURE_DEPENDS "*.cpp")
-list(FILTER _src EXCLUDE REGEX "/Support/(Inferutil|Common)/")
+# Case-insensitive EXCLUDE: Windows filesystem may return lowercase paths
+# (e.g. "support/common") while git/Linux uses "Support/Common". The regex
+# uses character classes to match both cases on all platforms.
+list(FILTER _src EXCLUDE REGEX "/[Ss]upport/([Ii]nferutil|[Cc]ommon)/")
 
 find_package(stdcorelib CONFIG REQUIRED)
 find_package(nlohmann_json CONFIG REQUIRED)

lib/G2P/Core/Manager.cpp

@@ -104,9 +104,37 @@ namespace srt::g2p {
             srt::core::ContextKey defaultCtx("");
             const auto moduleInfos = this->getModuleMetadatas(defaultCtx);
             if (moduleInfos.empty()) {
+                // Diagnostic: log registered paths and their filesystem status
+                // to identify why the default context has no modules. Remove
+                // after root cause is identified.
+                const auto paths = this->packagePaths(defaultCtx.context, defaultCtx.version);
+                std::string diag;
+                for (size_t i = 0; i < paths.size(); ++i) {
+                    if (i > 0) diag += "; ";
+                    diag += stdc::path::to_utf8(paths[i]);
+                    diag += fs::exists(paths[i]) ? " (exists" : " (missing";
+                    if (fs::is_directory(paths[i])) {
+                        diag += ",dir";
+                        std::error_code ec;
+                        int subDirs = 0;
+                        int withPkgJson = 0;
+                        for (const auto &entry : fs::directory_iterator(paths[i], ec)) {
+                            if (!entry.is_directory()) continue;
+                            ++subDirs;
+                            if (fs::exists(entry.path() / "package.json")) ++withPkgJson;
+                        }
+                        diag += ",subDirs=" + std::to_string(subDirs);
+                        diag += ",withPkgJson=" + std::to_string(withPkgJson);
+                    } else {
+                        diag += ",notDir";
+                    }
+                    diag += ")";
+                }
                 g2pLog.srtWarning(
-                    "Ord-1: Default context has no modules; official G2P unavailable "
-                    "(voicebank-private G2P still initializes in Phase 2)");
+                    "Ord-1: Default context has no modules (paths: [%1]); "
+                    "official G2P unavailable "
+                    "(voicebank-private G2P still initializes in Phase 2)",
+                    diag);
             } else {
                 auto compatibleModules = filterCompatibleModules(moduleInfos);
                 if (compatibleModules.empty()) {