Skip to content
This repository was archived by the owner on Jun 13, 2020. It is now read-only.

Fixed autocomplete issue in Chrome#181

Open
aponigricon wants to merge 4 commits into
ctrlcctrlv:masterfrom
aponigricon:master
Open

Fixed autocomplete issue in Chrome#181
aponigricon wants to merge 4 commits into
ctrlcctrlv:masterfrom
aponigricon:master

Conversation

@aponigricon

Copy link
Copy Markdown
Contributor

This issue has been annoying me for several days now, so I decided to do something about it. This should remove all of Chrome's autocomplete shit once and for all.

@czaks

czaks commented Oct 15, 2014

Copy link
Copy Markdown
Collaborator

i thought i fixed autocomplete issue with my commit adding dummy fields before password

@aponigricon

Copy link
Copy Markdown
Contributor Author

@czaks Yeah, I noticed those, but it seems that you only took into account quick reply. On top of that, your dummy fields were not before password, but after, at the bottom, which was why they did not work. This should have been corrected now, though.

@aponigricon

Copy link
Copy Markdown
Contributor Author

Is anyone going to merge this?

@aponigricon

Copy link
Copy Markdown
Contributor Author

This pull request, along with countless others, have neither been merged nor closed for weeks. Is anyone reviewing these?

@ctrlcctrlv

Copy link
Copy Markdown
Owner

Welcome to open source projects @VladVP ...

Some patches to MySQL have not been accepted for over a decade. Please don't feel slighted, I have a lot on my plate.

Re: this...I really don't get it. Seems like Chrome is broken to me. This commit is an ugly hack. Not only that, @czaks is rewriting the post box soon(TM)...

I suppose I can accept it for now...but the post form code is so complicated I don't like accepting new commits because even with good testing bugs are bound to arise.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants