fix: bound service account baseline permission checks#313
Merged
markussiebert merged 3 commits intoJul 7, 2026
Conversation
Signed-off-by: Henry Sachs <henry.sachs@deutschebahn.com>
Signed-off-by: Henry Sachs <henry.sachs@deutschebahn.com>
Rebase #313 onto current master: - Update gitlab client imports from client-go to client-go/v2 in the instance serviceaccounts helpers/tests (namespaced + regenerated cluster). - Fix the new baseline-permissions test to the v2 API: *gitlab.GetUserOptions (was gitlab.GetUsersOptions) and v2.Available() (was xpv1.Available()); drop the now-unused cmpopts import. - Keep golang.org/x/sync as a direct dependency (errgroup) and master's newer golang.org/x/* versions. - Regenerate the cluster zz_ mirror. Signed-off-by: Markus Siebert <markus.siebert@deutschebahn.com>
c4f6089 to
1f653c2
Compare
Collaborator
|
Rebased onto current
Review: the change looks good — bounded concurrency via |
dariozachow
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up for the baselinePermissions reconcile path added in #302.
This change makes the instance service account baseline permission flow safer and more stable under larger GitLab installations.
errgroupand a concurrency limit of16ctxinto observe-side group membership checksCloses #310
Testing