Conversation
jdubba1
marked this pull request as ready for review
September 11, 2026 19:22
jdubba1
marked this pull request as draft
September 11, 2026 19:24
crmne
reviewed
Sep 12, 2026
Owner
There was a problem hiding this comment.
The approved Theme picker and local JSON palettes are integrated in ee16697. The included Omarchy template and hook reload colours without restarting playback or opening the window. All nine local checks, the light/dark visual review, isolated Omarchy checks and Linux, macOS, Windows and Nix CI pass. This is on main and has not been released yet. Thanks for the contribution.
This was referenced Sep 12, 2026
Owner
|
Please post screenshots of various themes. |
crmne
pushed a commit
that referenced
this pull request
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry but I need themes so badly.... hopefully this is a lightweight option you can accept, tried to make this as minimal as possible so it can be easily superseded by a more comprehensive theming system. I've been doing this on my fork for a while, so thought it would be good to open a PR.
0-- how it works -0>
Load custom color palettes from JSON files in a
themesfolder besidesettings.json, and select them in Appearance's Theme picker. Files inherit a dark/light palette; invalid or missing themes fall back to the built-in choice. No new dependencies.Validated on macOS: 483 core/demo tests passed (one native credential-store test ignored), strict Clippy, rustfmt, Rust docs, and 27 assessment-script tests. Visually checked built-in and custom palettes in an isolated demo config.
Full-feature checks are blocked locally by MilkDrop's missing Boost dependency; the website build needs Bundler 4.0.16. Linux/Windows remain for CI.