Skip to content

Initial commit#33033

Open
jshirota wants to merge 5 commits intoconda-forge:mainfrom
jshirota:main
Open

Initial commit#33033
jshirota wants to merge 5 commits intoconda-forge:mainfrom
jshirota:main

Conversation

@jshirota
Copy link
Copy Markdown

No description provided.

Copilot AI review requested due to automatic review settings April 19, 2026 13:43
@conda-forge-admin
Copy link
Copy Markdown
Contributor

conda-forge-admin commented Apr 19, 2026

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/glidergun/meta.yaml) and found some lint.

Here's what I've got...

For recipes/glidergun/meta.yaml:

  • ❌ The outputs section contained an unexpected subsection name. noarch is not a valid subsection name.

For recipes/glidergun/meta.yaml:

  • ℹ️ Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/24632302783. Examine the logs at this URL for more detail.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new conda-build (v0) recipe intended to package glidergun and a companion glidergun-torch metapackage within this staged-recipes repository.

Changes:

  • Introduces a new multi-output meta.yaml recipe for glidergun and glidergun-torch.
  • Defines runtime dependencies and basic import/command tests for both outputs.
  • Adds package metadata (home/summary/license) and recipe maintainer info.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread recipes/glidergun/meta.yaml
Comment thread recipes/meta.yaml Outdated
Comment thread recipes/glidergun/meta.yaml
Comment thread recipes/glidergun/meta.yaml Outdated
- python -c "import glidergun; print('glidergun import ok')"

- name: glidergun-torch
noarch: generic
Copy link

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a v0 meta.yaml recipe, noarch is a key under the build: section (see recipes/example/meta.yaml). Here it's specified directly under the output, which conda-build may treat as an unknown key and error. Please nest this under build: for the glidergun-torch output (and include any other build-related keys there).

Suggested change
noarch: generic
build:
noarch: generic

Copilot uses AI. Check for mistakes.
- kornia >=0.8.2
test:
commands:
- python -c "import glidergun; print('glidergun-torch deps ok')"
Copy link

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The glidergun-torch output is a dependency/metapackage, but its test only imports glidergun. To actually validate the extra dependencies this output adds, the test should also import (or otherwise check) torch and kornia so missing/incorrect dependency specs get caught during CI.

Suggested change
- python -c "import glidergun; print('glidergun-torch deps ok')"
- python -c "import glidergun, torch, kornia; print('glidergun-torch deps ok')"

Copilot uses AI. Check for mistakes.
@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/glidergun/meta.yaml) and found it was in an excellent condition.

@jshirota jshirota force-pushed the main branch 3 times, most recently from 00fa8a9 to f13935c Compare April 19, 2026 18:49
@conda-forge-admin
Copy link
Copy Markdown
Contributor

conda-forge-admin commented Apr 19, 2026

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/glidergun/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/glidergun/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/24638356936. Examine the logs at this URL for more detail.

@jshirota jshirota force-pushed the main branch 3 times, most recently from 584ccb1 to dd2b945 Compare April 19, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants