Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/glidergun/meta.yaml:
For recipes/glidergun/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/24632302783. Examine the logs at this URL for more detail. |
There was a problem hiding this comment.
Pull request overview
Adds a new conda-build (v0) recipe intended to package glidergun and a companion glidergun-torch metapackage within this staged-recipes repository.
Changes:
- Introduces a new multi-output
meta.yamlrecipe forglidergunandglidergun-torch. - Defines runtime dependencies and basic import/command tests for both outputs.
- Adds package metadata (home/summary/license) and recipe maintainer info.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - python -c "import glidergun; print('glidergun import ok')" | ||
|
|
||
| - name: glidergun-torch | ||
| noarch: generic |
There was a problem hiding this comment.
In a v0 meta.yaml recipe, noarch is a key under the build: section (see recipes/example/meta.yaml). Here it's specified directly under the output, which conda-build may treat as an unknown key and error. Please nest this under build: for the glidergun-torch output (and include any other build-related keys there).
| noarch: generic | |
| build: | |
| noarch: generic |
| - kornia >=0.8.2 | ||
| test: | ||
| commands: | ||
| - python -c "import glidergun; print('glidergun-torch deps ok')" |
There was a problem hiding this comment.
The glidergun-torch output is a dependency/metapackage, but its test only imports glidergun. To actually validate the extra dependencies this output adds, the test should also import (or otherwise check) torch and kornia so missing/incorrect dependency specs get caught during CI.
| - python -c "import glidergun; print('glidergun-torch deps ok')" | |
| - python -c "import glidergun, torch, kornia; print('glidergun-torch deps ok')" |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
00fa8a9 to
f13935c
Compare
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/glidergun/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/24638356936. Examine the logs at this URL for more detail. |
584ccb1 to
dd2b945
Compare
No description provided.