fix: apply second-round copilot review suggestions

- Rename pure helper useVersionTags to getVersionTags
- Format publish dates in local time instead of UTC
- Drop maintainer email (PII) from the UI
- Use type=search with a stable name and autocomplete off
- Replace test setTimeout waits with waitFor

Author: thonatos

apps/web/app/components/cnpm/MaintainersCard.tsx

@@ -31,9 +31,6 @@ function MaintainerRow({ maintainer }: { maintainer: Maintainer }) {
       </Avatar>
       <div className="min-w-0">
         <div className="truncate text-sm font-medium text-foreground">{maintainer.name}</div>
-        {maintainer.email && (
-          <div className="truncate text-xs text-muted-foreground">{maintainer.email}</div>
-        )}
       </div>
     </div>
   );

apps/web/app/components/cnpm/NpmSearchForm.tsx

@@ -43,7 +43,9 @@ export function NpmSearchForm({
           <SearchIcon className={large ? "size-5" : "size-4"} />
         </InputGroupAddon>
         <InputGroupInput
-          type="text"
+          type="search"
+          name="q"
+          autoComplete="off"
           value={value}
           autoFocus={autoFocus}
           onChange={(event) => setValue(event.target.value)}

apps/web/app/components/cnpm/PkgHeader.tsx

@@ -9,7 +9,7 @@ import {
 } from "~/components/ui/select";
 import { Badge } from "~/components/ui/badge";
 import { Button } from "~/components/ui/button";
-import { sortVersions, useVersionTags, type PkgTab } from "~/lib/registry/parse";
+import { sortVersions, getVersionTags, type PkgTab } from "~/lib/registry/parse";
 import type { RegistryManifest } from "~/lib/registry/types";
 import { PkgTabs } from "./PkgTabs";
 
@@ -39,7 +39,7 @@ export function PkgHeader({
   onVersionChange: (version: string) => void;
 }) {
   const versions = sortVersions(manifest.versions);
-  const tags = useVersionTags(manifest);
+  const tags = getVersionTags(manifest);
   const [copied, setCopied] = useState(false);
   const installCommand = `npm install ${manifest.name}@${version}`;
   const repo = repoUrl(manifest.repository);

apps/web/app/components/cnpm/VersionTable.tsx

@@ -8,20 +8,23 @@ import {
   TableRow,
 } from "~/components/ui/table";
 import { Badge } from "~/components/ui/badge";
-import { sortVersions, useVersionTags } from "~/lib/registry/parse";
+import { sortVersions, getVersionTags } from "~/lib/registry/parse";
 import type { RegistryManifest } from "~/lib/registry/types";
 
 function formatDate(value: number | string | undefined) {
   if (value === undefined || value === null || value === "") return "-";
   const numeric = typeof value === "string" && /^\d+$/.test(value) ? Number(value) : value;
   const date = new Date(numeric);
   if (Number.isNaN(date.getTime())) return "-";
-  return date.toISOString().slice(0, 10);
+  const year = date.getFullYear();
+  const month = String(date.getMonth() + 1).padStart(2, "0");
+  const day = String(date.getDate()).padStart(2, "0");
+  return `${year}-${month}-${day}`;
 }
 
 export function VersionTable({ manifest, version }: { manifest: RegistryManifest; version: string }) {
   const versions = sortVersions(manifest.versions);
-  const tags = useVersionTags(manifest);
+  const tags = getVersionTags(manifest);
 
   return (
     <Table>

apps/web/app/lib/registry/parse.ts

@@ -43,7 +43,7 @@ export function normalizeVersionSpec(spec: string | undefined) {
   return spec;
 }
 
-export function useVersionTags(manifest: RegistryManifest): Record<string, string[]> {
+export function getVersionTags(manifest: RegistryManifest): Record<string, string[]> {
   const tagsMap = manifest["dist-tags"] || {};
   const result: Record<string, string[]> = {};
   for (const [tag, version] of Object.entries(tagsMap)) {

apps/web/tests/CnpmRegistry.test.tsx

@@ -1,4 +1,4 @@
-import { render, screen } from "@testing-library/react";
+import { render, screen, waitFor } from "@testing-library/react";
 import { createMemoryRouter, RouterProvider } from "react-router";
 import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
 import { REGISTRY } from "~/lib/registry/client";
@@ -71,7 +71,7 @@ describe("cnpm landing", () => {
     renderRoute(<CnpmLanding />, "/cnpm");
 
     expect(screen.getByRole("search")).toBeInTheDocument();
-    expect(screen.getByRole("textbox", { name: "搜索 npm 包" })).toBeInTheDocument();
+    expect(screen.getByRole("searchbox", { name: "搜索 npm 包" })).toBeInTheDocument();
     expect(screen.getByRole("link", { name: "react" })).toHaveAttribute("href", "/cnpm/pkg/react");
     expect(await screen.findByText("包数量")).toBeInTheDocument();
     expect(screen.getByText("6m")).toBeInTheDocument();
@@ -86,8 +86,9 @@ describe("cnpm landing", () => {
     );
 
     renderRoute(<CnpmLanding />, "/cnpm");
-    await new Promise((resolve) => setTimeout(resolve, 20));
-    expect(screen.queryByText("包数量")).not.toBeInTheDocument();
+    await waitFor(() => {
+      expect(screen.queryByText("包数量")).not.toBeInTheDocument();
+    });
   });
 });