move compile time tests to the right places, remove default directive compile time tests

Author: swannodette

src/test/cljs/cljs/destructuring_test.cljs

@@ -442,9 +442,7 @@
     (testing "all turns nothing into something"
       (is (= {:a 42} (let [{:keys [a] :or {a 42} :all m} nil] m)))
       (is (= {:a 42} (let [{:keys [a] :or {a 42} :all m} {}] m)))
-      (is (= {:n {:a 42}} (let [{{a :a :or {a 42}} :n :all m} {:n nil}] m))))
-    #_(testing ":or defaults must correspond to binding with :all"
-      (is (thrown? Exception (eval '(let [{:keys [a] :or {a 1 z 2} :all m} {}] m))))))
+      (is (= {:n {:a 42}} (let [{{a :a :or {a 42}} :n :all m} {:n nil}] m)))))
   (testing ":or defaults applied in :all"
     (is (= {:a 1}       (let [{:keys [a] :or {a 42} :all m} {:a 1}] m)))
     (is (= {:n {:a 42}} (let [{{a :a :or {a 42}} :n :all m} nil] m)))
@@ -460,9 +458,7 @@
     (is (= {:z 42 :a 1 :b 2}
            (let [{:keys [a b & :c :z] :or {:z 42} :all m} {:a 1 :b 2}] m)))
     (is (= {:z 100 :a 1 :b 2}
-           (let [{:keys [a b & :c :z] :or {:z 42} :all m} {:a 1 :b 2 :z 100}] m)))
-    #_(testing ":or defaults must correspond to binding with :all plus &"
-      (is (thrown? Exception (eval '(let [{:keys [a b & :c] :or {c 42} :all m} {:a 1 :b 2}] m))))))
+           (let [{:keys [a b & :c :z] :or {:z 42} :all m} {:a 1 :b 2 :z 100}] m))))
   (testing "combinations"
     (let [sample-map {:a 1, :b 2, :c {:aa 10},
                       'd 4, 'e 5, 'f {'dd 40},

src/test/clojure/cljs/compiler_tests.clj

@@ -452,7 +452,6 @@
 (deftest syms-bang
   (testing "that right of & is unbound (compile-time errors)"
     (is (undeclared-warning? '(let [{:syms! [a & 'b]} (quote {a 1 b 2})] b) 'b))
-    #_(is (undeclared-warning? '(let [{a a {aa a :as m :syms [b c & 'e]} :b} (quote {a 1 b 2})] e) 'e))
     (is (undeclared-warning? '(let [{:syms! [foo/a & 'foo/c]} (quote {a 1 b 2})] c) 'c))
     (is (undeclared-warning? '(let [{:foo/syms! [foo/aa & 'foo/cc]} (quote {foo/aa 1 bb 2 foo/cc 3})] cc) 'cc))))
 
@@ -461,14 +460,11 @@
     (is (undeclared-warning? '(let [{:strs! [a & "b"]} {"a" 1 "b" 2}] b) 'b))
     (is (undeclared-warning? '(let [{a "a" {aa "a" :as m :keys [b c & "e"]} "b"} {"a" 1 "b" 2}] e) 'e))))
 
-(deftest select-or-defaults
-  (testing ":defaults"
-    (is (thrown? Exception
-          (compile-simple-form
-            '(let [{:defaults d :or {:a 1}} {}] d)))))
-  (testing "known compile-time errors"
-    (is (thrown? Exception (compile-simple-form '(let [{:keys [a] :defaults d :or {:a 1, a 1}} {}] d))))
-    (is (thrown? Exception (compile-simple-form '(let [{:defaults d} {}] d))))))
+(deftest all-directive
+  (testing ":or defaults must correspond to binding with :all"
+    (is (thrown? Exception (compile-simple-form '(let [{:keys [a] :or {a 1 z 2} :all m} {}] m)))))
+  (testing ":or defaults must correspond to binding with :all plus &"
+    (is (thrown? Exception (compile-simple-form '(let [{:keys [a b & :c] :or {c 42} :all m} {:a 1 :b 2}] m))))))
 
 ;; CLJS-1225