You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ci(repo): hash environment variables only into the tasks they affect - #10667
Scopes the variables in globalEnv to the tasks they affect, following Turbo's rules for environment variables: a variable that changes a task's output goes in that task's env, and a variable a task only needs at runtime goes in a pass-through list, which isn't hashed.
NODE_VERSION moves to the test task
CI sets NODE_VERSION only in the Unit Tests steps (24.15.0 or 20.19.0), and the Build Packages job doesn't set it. Because it was in globalEnv, each package build had three cache keys, one per job:
NODE_VERSION
@clerk/clerk-js#build before
after
unset (Build Packages)
1e99830997e4d0ca
22193a379805db24
24.15.0 (Unit Tests)
bfb74d663908a326
22193a379805db24
20.19.0 (Unit Tests)
6d504020eae9134a
22193a379805db24
As a result, both Unit Tests jobs rebuilt every package a PR changed, even though Build Packages had just built it. On recent PRs that cost 40 to 70 seconds per job. With this change, both Unit Tests jobs download all 26 builds from the cache. Test results keep a separate cache entry per Node version, so the Node 20 job still runs its own tests.
The other entries
Variable
Before
After
Why
NPM_VERSION, NEXT_PHASE
globalEnv
removed
Nothing reads them. Next.js sets NEXT_PHASE inside its own build.
RSDOCTOR
globalEnv
env of the clerk-js build and build:sandbox tasks and the ui build task
Only their rspack configs read it.
TZ
globalEnv
env of the test task, plus globalPassThroughEnv
The time zone can change test results but not build output. Other tasks still receive it.
SDK code reads them at runtime in customer apps, not during our builds. Turbo hashes VERCEL_TARGET_ENV on its own anyway.
NODE_ENV and the CLERK_* families
globalEnv
unchanged
Build configs read NODE_ENV. The integration test apps read the CLERK_* families, so the integration tasks need them hashed. Moving those into each integration task's env can follow the integration suite changes in #10648, #10653 and #10661.
Every task's hash changes once, so the first run after merge rebuilds everything.
Checklist
pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
NODE_VERSION was in globalEnv, so the Unit Tests jobs (which set it per Node version) computed different build hashes from the Build Packages job (which does not set it) and rebuilt every package the PR changed. Scoping it to the test task keeps test results separate per Node version and lets every job share build cache entries.
No actionable comments were generated in the recent review.
Walkthrough
The root Turbo configuration moves several environment variables out of globalEnv, adds TZ and Vercel variables to globalPassThroughEnv, and adds NODE_VERSION and TZ to the test task environment. The build and build:sandbox tasks in packages/clerk-js, and the build task in packages/ui, add RSDOCTOR to their environment inputs. A changeset file adds two empty YAML delimiters.
The environment changes match the repository’s configured Turbo workflows and are safe to merge.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title "ci(repo): hash environment variables only into the tasks they affect" matches the main change. The PR scopes Turbo environment variables from globalEnv to the tasks that use them. The main …
Description check
The description states that it scopes globalEnv variables to the tasks they affect. It explains the NODE_VERSION move to the test task, the handling of NPM_VERSION, NEXT_PHASE, RSDOCTOR, TZ, and the V…
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "ci(repo): hash environment variables only into the tasks they affect" matches the main change. The PR scopes Turbo environment variables from globalEnv to the tasks that use them. The main example is moving NODE_VERSION into the test task. The title is concise and specific, and it follows the conventional commit style.
Full details: Description check
Explanation
The description states that it scopes globalEnv variables to the tasks they affect. It explains the NODE_VERSION move to the test task, the handling of NPM_VERSION, NEXT_PHASE, RSDOCTOR, TZ, and the VERCEL variables, and the cache impact. It is detailed and directly related to the changeset.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.
Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.
…ks they affect
Remove NPM_VERSION and NEXT_PHASE, which nothing reads. Hash RSDOCTOR only into the clerk-js and ui builds that read it, and TZ only into tests. Pass TZ and the VERCEL variables through to tasks without hashing them, since they don't change any task's output.
austincalvelage
changed the title
ci(repo): hash NODE_VERSION only into test tasks
ci(repo): hash environment variables only into the tasks they affect
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
austincalvelage
changed the title
Description
Scopes the variables in
globalEnvto the tasks they affect, following Turbo's rules for environment variables: a variable that changes a task's output goes in that task'senv, and a variable a task only needs at runtime goes in a pass-through list, which isn't hashed.NODE_VERSIONmoves to thetesttaskCI sets
NODE_VERSIONonly in the Unit Tests steps (24.15.0or20.19.0), and the Build Packages job doesn't set it. Because it was inglobalEnv, each package build had three cache keys, one per job:NODE_VERSION@clerk/clerk-js#buildbefore1e99830997e4d0ca22193a379805db2424.15.0(Unit Tests)bfb74d663908a32622193a379805db2420.19.0(Unit Tests)6d504020eae9134a22193a379805db24As a result, both Unit Tests jobs rebuilt every package a PR changed, even though Build Packages had just built it. On recent PRs that cost 40 to 70 seconds per job. With this change, both Unit Tests jobs download all 26 builds from the cache. Test results keep a separate cache entry per Node version, so the Node 20 job still runs its own tests.
The other entries
NPM_VERSION,NEXT_PHASEglobalEnvNEXT_PHASEinside its own build.RSDOCTORglobalEnvenvof the clerk-jsbuildandbuild:sandboxtasks and the uibuildtaskTZglobalEnvenvof thetesttask, plusglobalPassThroughEnvVERCEL,VERCEL_PROJECT_PRODUCTION_URL,VERCEL_TARGET_ENVglobalEnvglobalPassThroughEnvVERCEL_TARGET_ENVon its own anyway.NODE_ENVand theCLERK_*familiesglobalEnvNODE_ENV. The integration test apps read theCLERK_*families, so the integration tasks need them hashed. Moving those into each integration task'senvcan follow the integration suite changes in #10648, #10653 and #10661.Every task's hash changes once, so the first run after merge rebuilds everything.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change