test(mosaic): consolidate reverification overlay coverage

Author: austincalvelage

packages/mosaic/src/features/reverification/__tests__/reverification.controller.test.ts

@@ -158,68 +158,3 @@ describe('reverification interrupted requests', () => {
     actor.stop();
   });
 });
-
-describe('reverification preparation overlays', () => {
-  it('blocks leaving a pending picker and preserves help opened over the factor', async () => {
-    const effects = deps();
-    const pending = deferred<ReverificationPreparation>();
-    effects.prepare = vi.fn(() => pending.promise);
-    const actor = createActor(reverificationMachine, { context: { deps: effects } }).start();
-    actor.send({ type: 'START', scope: { runId: Symbol(), sessionId: 'session' } });
-    await tick();
-    actor.send({ type: 'SHOW_HELP' });
-    expect(actor.getSnapshot().context.overlay).toEqual(['help']);
-    expect(actor.can({ type: 'BACK' })).toBe(true);
-    actor.send({ type: 'BACK' });
-    actor.send({ type: 'SHOW_METHODS' });
-    actor.send({ type: 'SELECT_METHOD', id: work.id });
-    expect(actor.can({ type: 'BACK' })).toBe(false);
-    expect(actor.can({ type: 'SHOW_HELP' })).toBe(false);
-    actor.send({ type: 'BACK' });
-    actor.send({ type: 'SHOW_HELP' });
-    expect(actor.getSnapshot().context.overlay).toEqual(['method-picker']);
-    actor.stop();
-  });
-
-  it('keeps help visible when the send behind it settles', async () => {
-    const effects = deps();
-    const pending = deferred<ReverificationPreparation>();
-    effects.prepare = vi.fn(() => pending.promise);
-    const actor = createActor(reverificationMachine, { context: { deps: effects } }).start();
-    actor.send({ type: 'START', scope: { runId: Symbol(), sessionId: 'session' } });
-    await tick();
-    actor.send({ type: 'SHOW_HELP' });
-    pending.resolve({ reusableUntil: Date.now() + 60_000 });
-    await tick();
-    expect(actor.getSnapshot().context.overlay).toEqual(['help']);
-    expect(actor.getSnapshot().context.operation).toBeNull();
-    actor.send({ type: 'BACK' });
-    expect(actor.getSnapshot().context.overlay).toEqual([]);
-    actor.stop();
-  });
-});
-
-it.each([false, true])(
-  'keeps a picker opened over the original pending factor when the send settles (failure %s)',
-  async fails => {
-    const effects = deps();
-    const pending = deferred<ReverificationPreparation>();
-    effects.prepare = vi.fn(() => pending.promise);
-    const actor = createActor(reverificationMachine, { context: { deps: effects } }).start();
-    actor.send({ type: 'START', scope: { runId: Symbol(), sessionId: 'session' } });
-    await tick();
-    actor.send({ type: 'SHOW_METHODS' });
-    expect(actor.can({ type: 'BACK' })).toBe(true);
-    expect(actor.can({ type: 'SHOW_HELP' })).toBe(true);
-    if (fails) {
-      pending.reject({ code: 'form_identifier_not_found', message: 'Unknown identifier' });
-    } else {
-      pending.resolve({ reusableUntil: Date.now() + 60_000 });
-    }
-    await tick();
-    expect(actor.getSnapshot().context.overlay).toEqual(['method-picker']);
-    actor.send({ type: 'BACK' });
-    expect(actor.getSnapshot().context.overlay).toEqual([]);
-    actor.stop();
-  },
-);

packages/mosaic/src/features/reverification/__tests__/reverification.feature.test.tsx

@@ -677,12 +677,20 @@ describe('Reverification', () => {
         },
       );
 
-      it('keeps the cooldown of a code sent while the picker is open', async () => {
+      it.each(['picker', 'help'] as const)('keeps the cooldown of a code sent while the %s is open', async step => {
         const { prepare, user } = await startSendingCode();
         await useAnotherMethod(user);
+        if (step === 'help') {
+          await user.click(await screen.findByRole('button', { name: 'Get help' }));
+          expect(await screen.findByText(/If you have trouble verifying your account/)).toBeVisible();
+        }
 
         prepare.release();
         await settle();
+        if (step === 'help') {
+          expect(screen.getByText(/If you have trouble verifying your account/)).toBeVisible();
+          await back(user);
+        }
         expect(screen.getByRole('button', { name: 'Continue with your password' })).toBeVisible();
         await back(user);
 
@@ -1196,6 +1204,7 @@ describe('Reverification', () => {
       await waitFor(() => expect(secondPrepare.requests).toHaveLength(1));
       expect(method('Continue with your password')).toBeDisabled();
       expect(method('Back')).toBeDisabled();
+      expect(method('Get help')).toBeDisabled();
       secondPrepare.release();
       expect(await screen.findByText(STEP.phoneCode)).toBeVisible();
       expect(fapi.verification.firstFactorVerification?.strategy).toBe('phone_code');