Traceback in temp.py - AttributeError: 'NoneType' object has no attribute 'lower'

[lgmu]

Hi,
it's me again! In order to get the last fix you implemented, I've updated check_redfish today for all of our hosts.
It was a quite big jump from 1.12.1 to 2.1.2 (next-release), but almost everything still works.

I noticed a problem with the temp module.

It happens on both Dell (e.g. Dell Inc. PowerEdge C6520/ C6620 ) and HPE (e.g. HPE ProLiant DL360 Gen10/ DL560 Gen10). At first I thought it was related to the HPE server being shut down (Power: Off), but the Dell is running and it still happens there.

It's also strange that this only affects like 20 out of 1000+ hosts of the same model.

I'll try and get a mockup of a failing one.

[Traceback (most recent call last):
  File "/omd/sites/mon/local/lib/monitoring-plugins/mon/check_redfish/check_redfish.py", line 76, in 
    main()
  File "/omd/sites/mon/local/lib/monitoring-plugins/mon/check_redfish/check_redfish.py", line 73, in main
    CheckRedfish().main()
  File "/omd/sites/mon/local/lib/monitoring-plugins/mon/check_redfish/check_redfish.py", line 57, in main
    if any(x in self.args.requested_query for x in ['temp', 'all']):     get_chassis_data(Temperature)
  File "/opt/omd/sites/mon/local/lib/monitoring-plugins/mon/check_redfish/cr_module/system_chassis.py", line 135, in get_chassis_data
    get_single_chassis_temp(discovered_url, chassis_id, discovered_url_data)
  File "/opt/omd/sites/mon/local/lib/monitoring-plugins/mon/check_redfish/cr_module/temp.py", line 143, in get_single_chassis_temp
    if add_temp_status(temp_inventory, chassis_id, num_chassis, system_power_state) is True:
  File "/opt/omd/sites/mon/local/lib/monitoring-plugins/mon/check_redfish/cr_module/temp.py", line 27, in add_temp_status
    if state.lower() in ["absent", "disabled", "disable", "unavailableoffline", "standbyoffline"]:
AttributeError: 'NoneType' object has no attribute 'lower']

[bb-Ricardo]

Hey, thank you for the report. Can you please try the next-release branch? I just pushed a commit which should fix this problem. Could you please try it?

Thank you.

[lgmu]

Works perfect, thank you for the quick fix!

While we're already at it, maybe we can fix this one too? I get this on one of 50 Dell Inc. PowerEdge XE9680 hosts:

[Traceback (most recent call last):
  File "/omd/sites/mon/local/lib/monitoring-plugins/mon/check_redfish/check_redfish.py", line 76, in 
    main()
  File "/omd/sites/mon/local/lib/monitoring-plugins/mon/check_redfish/check_redfish.py", line 73, in main
    CheckRedfish().main()
  File "/omd/sites/mon/local/lib/monitoring-plugins/mon/check_redfish/check_redfish.py", line 65, in main
    if any(x in self.args.requested_query for x in ['firmware', 'all']): get_firmware_info()
  File "/opt/omd/sites/mon/local/lib/monitoring-plugins/mon/check_redfish/cr_module/firmware.py", line 43, in get_firmware_info
    get_firmware_info_generic()
  File "/opt/omd/sites/mon/local/lib/monitoring-plugins/mon/check_redfish/cr_module/firmware.py", line 401, in get_firmware_info_generic
    for firmware_member in firmware_response.get("Members"):
TypeError: 'NoneType' object is not iterable]

[bb-Ricardo]

great that this one worked.

I don't have a mockup of this kind of server. Would it be ok to create one and send it over? Here is the description of how to create a mockup: https://github.com/bb-Ricardo/check_redfish/tree/next-release#contribution

Thank you.

[lgmu]

Actually I found out it happens on a few more:

• Dell Inc. PowerEdge R760
• Dell Inc. PowerEdge R6615
• Dell Inc. PowerEdge C6520

Do you still need a mockup?

[bb-Ricardo]

I have two of the tree mockups. But it doesn't happen with the ones I have. Let's see. But will be taking a while as I'm currently traveling.

[lgmu]

Mockup sent.

[bb-Ricardo]

Thank you very much. I had a look but cannot find it. Did you use the usual eMail address? Did you get a Mailserver complaint?

[lgmu]

yes! I received the out of office message until "August 17th 20206" 😄

[bb-Ricardo]

Ahh, you sent it this one. Great, then you know when I will be able to work on this 😬.