Repository navigation
[GLUTEN-12856][TEST] Use withTable for table cleanup in Hive SQL query suites - #13405
Open
shivadarshan-devadiga wants to merge 2 commits into
Open
shivadarshan-devadiga wants to merge 2 commits into
shivadarshan-devadiga wants to merge 2 commits into
Conversation
Contributor
Author
|
@zhouyuan @LuciferYang @philo-he Can you please take a look |
|
Run Gluten Clickhouse CI on x86 |
Contributor
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Fixes #12856
The Hive SQL query suites created persistent Hive tables and dropped them only after the assertions ran. The drop was a plain statement outside
withTableor afinally, so a failed assertion skipped it. The Hive suites share oneTestHivesingleton, so the leftover table stayed in the metastore and warehouse, and later cases in the same JVM could see it. Some cases also mixed two cleanup styles: aDROP TABLE IF EXISTSat the start of the body andspark.sessionState.catalog.dropTable(...)at the end.This PR wraps each affected case in
withTable(...)and removes the manual drops, across all five modules (gluten-ut/spark34,spark35,spark40,spark41,spark42)How was this patch tested?
CI
Was this patch authored or co-authored using generative AI tooling?
No