feat(core): add get_prior_action() to Application#800
Open
section9-lab wants to merge 1 commit into
Open
Conversation
Adds the symmetric counterpart to get_next_action(). The data already lives in state under __PRIOR_STEP -- this exposes it as a public API. Returns None when no step has been executed yet (app at entrypoint). Closes apache#502
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
Application.get_prior_action()as the symmetric counterpart toget_next_action().Actionthat was executed in the most recent stepNonewhen no step has been executed yet (application is at its entrypoint)__PRIOR_STEP; this simply exposes it as a first-class public APICloses #502
Changes
burr/core/application.py: addget_prior_action()next toget_next_action()tests/core/test_application.py: addtest_app_get_prior_step()mirroring the existingtest_app_get_next_step()Test plan
test_app_get_prior_step— verifiesNonebefore any step, then correct action name after eachstep()calltest_app_get_next_stepstill passes