Merge pull request #1941 from apache/abderrahim/junction-remotes

_context: use artifact caches from the parent project for junctions

Author: abderrahim

src/buildstream/_context.py

@@ -807,6 +807,13 @@ def _resolve_specs_for_project(
 
         # If there are any project recommendations, append them at the end
         project_remotes = getattr(project, project_attribute)
+
+        junction = project.junction
+        while junction:
+            parent_project = junction._get_project()
+            project_remotes = getattr(parent_project, project_attribute) + project_remotes
+            junction = parent_project.junction
+
         remotes = list(utils._deduplicate(remotes + project_remotes))
 
         return remotes

tests/artifactcache/junctions.py

@@ -68,7 +68,7 @@ def test_push_pull(cli, tmpdir, datafiles):
         # In the parent project's cache
         assert_shared(cli, share, project, "target.bst", project_name="parent")
         assert_shared(cli, share, project, "app.bst", project_name="parent")
-        assert_not_shared(cli, share, base_project, "base-element.bst", project_name="base")
+        assert_shared(cli, share, base_project, "base-element.bst", project_name="base")
 
         # In the junction project's cache
         assert_not_shared(cli, base_share, project, "target.bst", project_name="parent")