Repository navigation
fix: repair the workflow v0.1.7 could not load, and move to client-id - #94
Merged
Merged
Conversation
The v0.1.7 reusable workflow does not run. The comment dispatch fix added a second `env:` block to the run step rather than adding to the first one. Duplicate keys are legal to yaml.safe_load, which keeps the last, so GH_TOKEN and both Azure variables were discarded. GitHub is stricter and refuses to load the file, so every run since that merge failed in about a second having started no job at all. The gate could not see it. It parsed workflows with yaml.safe_load, which is precisely the parser that accepts the file. It now rejects a duplicate key anywhere in a workflow, a template, or the embedded caller, and the check was written against the real v0.1.7 file to confirm it fails on it. Closes the deprecation warning at the same time, since it touches the same steps. `create-github-app-token` resolves `client-id || app-id` into a single value and passes it straight to createAppAuth, so the inputs are interchangeable in practice at v3.2.0 even though they are not in principle. Callers passing `github-app-id` keep working; the documented path is now SIMPLYCUBED_GH_APP_CLIENT_ID. Closes #93
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actual problem
v0.1.7shipped a reusable workflow that GitHub will not load.The comment dispatch fix in
a196683gave the run step a secondenv:block instead of adding to the existing one.yaml.safe_loadaccepts duplicate keys and keeps the last, soGH_TOKEN,AZURE_OPENAI_ENDPOINT, andAZURE_OPENAI_API_KEYwere all silently discarded. GitHub's parser is stricter and rejects the file outright.Every run since that merge failed in about a second with no job created and no log:
That includes the run triggered by filing #93 itself.
Why the gate missed it
The gate parsed workflows with
yaml.safe_load, the one parser that accepts the broken file. This is the second workflow defect to pass a gate that only compiles Go, after the conflict markers.scripts/check-workflows.shnow rejects a duplicate key anywhere in a workflow, template, or the embedded caller. It was written against the realv0.1.7file and fails on it:The #93 part
The issue's premise does not hold at
create-github-app-token@v3.2.0.main.jsline 21 iscore.getInput("client-id") || core.getInput("app-id"), and that single value goes straight tocreateAppAuth({appId}). There is no branch distinguishing them, so the swap was never risky.The token step now passes only
client-id, so no deprecated input is present and the warning is gone. A caller still passinggithub-app-idkeeps working through the fallback. The documented variable isSIMPLYCUBED_GH_APP_CLIENT_ID, already set on this repo, because GitHub is moving that direction.Verification
make checkgreen, including the new duplicate-key checkSIMPLYCUBED_GH_APP_IDreferences remain outside the deprecated inputgithub-app-client-id, matching the declared inputv0.1.7references remain outside the changelog and the status warningCloses #93