Repository navigation
Commit 835c1e2
authored
Stop the gate stamping VCS metadata into throwaway binaries (#122)
The loop works in a git worktree under the temp directory, and Go's VCS
stamping fails there:
error obtaining VCS status: exit status 128
Use -buildvcs=false to disable VCS stamping.
It fails before any repo code compiles, so every agent run reports a red
gate for a reason that has nothing to do with the change under test. A
gate that cannot run where the loop runs is not a gate, and one that fails
for unrelated reasons invites someone to weaken it.
The gate builds binaries it throws away. Stamping git metadata into them
buys nothing and couples the gate to git plumbing it does not need.
Nothing user-visible depends on it. buildinfo reads the module version
from debug.ReadBuildInfo, not the VCS stamp, and release binaries are
built separately in release.yml with the version passed via -ldflags.1 parent 3ba719c commit 835c1e2
1 file changed
Lines changed: 10 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
22 | 30 | | |
23 | | - | |
| 31 | + | |
24 | 32 | | |
25 | 33 | | |
26 | | - | |
| 34 | + | |
27 | 35 | | |
28 | 36 | | |
29 | 37 | | |
0 commit comments